Fix Telegram send failures for oversized messages (#244) by jmahotiedu · Pull Request #251 · sipeed/picoclaw

jmahotiedu · 2026-02-15T22:52:18Z

Description

Fix Telegram send failures for oversized outputs by splitting outbound content into ordered chunks.
Preserve placeholder behavior by editing the first chunk and sending remaining chunks sequentially.
Keep Telegram HTML parse mode with per-chunk plain-text fallback when HTML parsing fails.
Refactor Telegram split logic to use shared pkg/utils/SplitMessage (aligned with Refactor/base layer message split #436) instead of duplicated local splitting code.
Add shared message-splitting utility and tests in pkg/utils/message.go and pkg/utils/message_test.go.
Document and include tool-security hardening changes currently in this branch:
- Added pkg/tools/network_guard.go to validate web fetch targets and enforce non-private egress rules.
- Updated pkg/tools/web.go to apply network guard checks on initial and redirect targets.
- Strengthened filesystem boundary checks in pkg/tools/filesystem.go and tests.
- Added shell timeout/process-tree cleanup helpers in pkg/tools/shell_process_unix.go and pkg/tools/shell_process_windows.go, plus related shell tests.
- Updated pkg/tools/README.md and root README.md with security/tooling notes.

Type of Change

Bug fix (non-breaking change which fixes an issue)
Documentation update
Code refactoring (no functional changes, no api changes)

AI Code Generation

Mostly AI-generated (AI draft, Human verified/modified)

Linked Issue

Closes Telegram: message too long error on send #244

Technical Context

Reference: Refactor/base layer message split #436 (shared message split utility extraction to pkg/utils).
Reasoning: fix Telegram 4096-char failures while consolidating split behavior in a shared utility and documenting all branch-included security/tool helper additions.

Test Environment & Hardware

Hardware: PC
OS: Windows 11
Model/Provider: N/A
Channels: Telegram

Proof of Work (Optional)

Click to view verification commands

go test ./pkg/channels ./pkg/utils
go test ./pkg/tools

Checklist

My code/docs follow the style of this project.
I have performed a self-review of my own changes.
I have updated the documentation accordingly.

Phase 1 - Security regression baseline - add blocking tests for loopback and redirect-to-private web_fetch targets - add filesystem symlink escape and prefix-bypass restriction tests - add shell timeout test to verify child-process cleanup behavior Phase 2 - Web fetch egress guard - introduce stdlib-only fetch target validator for host/IP policy checks - enforce target validation before connect, during redirect, and in dial path - keep public constructor API and add internal test-aware constructor path Phase 3 - Canonical filesystem boundary enforcement - replace prefix checks with canonical workspace containment via filepath.Rel - canonicalize workspace and target paths with symlink-aware resolution - protect create/read/write/list/edit/append flows through shared validation Phase 4 - Shell timeout process-tree cleanup - switch command execution to explicit start/wait with timeout select - add OS-specific process tree helpers for unix process groups and taskkill on windows - preserve existing output contract and timeout messaging semantics Phase 5 - Documentation and contributor guidance - document web_fetch network boundary and complementary security model - add tool security checklist for future built-in tool additions Verification - go test ./pkg/tools -run TestWebTool_WebFetch_Blocks (via golang:1.25) - go test ./pkg/tools -run TestFilesystemTool_Restrict (via golang:1.25) - go test ./pkg/tools -run TestShellTool_Timeout_KillsChildProcesses (via golang:1.25) - go test ./pkg/tools -run TestWebTool_WebFetch_ (via golang:1.25) - go test ./pkg/tools -run TestFilesystemTool_ (via golang:1.25) - go test ./pkg/tools -run TestShellTool_ (via golang:1.25) - go test ./pkg/tools (via golang:1.25) - go generate ./... && go test ./... (via golang:1.25)

Leeaandrob · 2026-02-16T19:29:34Z

@Zepan Fixes Telegram send failures for oversized messages (#244). At +871 lines, this is larger than expected for a message splitting fix — worth reviewing the scope.

Recommendation: Review carefully. The issue is real (Telegram has a 4096 char limit), but #143 (already merged) addressed Discord splitting. Check if this PR overlaps with the existing implementation or adds Telegram-specific handling.

Leeaandrob · 2026-02-17T16:02:31Z

@jmahotiedu take look into the conflict.

jmahotiedu · 2026-02-17T18:20:11Z

@Leeaandrob I resolved the merge conflicts and pushed an update in 02291c7 (Merge origin/main into fix/telegram-message-length-244).

Resolved files:

telegram.go
filesystem.go
filesystem_test.go
I preserved the Telegram chunking/placeholder-edit fix and merged in the latest upstream changes for the tool-security files.
Verification run:

go test ./pkg/channels -run 'Telegram|Base'
go test ./pkg/channels
go test ./pkg/tools
Could you please re-check when you have a chance?

jmahotiedu · 2026-02-18T19:36:11Z

Quick update on #251:

merge conflict feedback was addressed in

huaaudio · 2026-02-18T22:32:41Z

Hi @jmahotiedu, thanks for the PR!
I'm moving the function from #143 to pkg/utils as a shared utility, so it's available to all channel implementations (see #436).
Could you please update telegram.go to call that function instead of duplicating the code? This will help maintain consistency across the codebase.
Thanks!

jmahotiedu · 2026-02-19T06:12:17Z

Hi @mymmrac, thanks for the review.

Updated telegram.go to use the shared utility in pkg/utils (from #436) instead of duplicating the split logic. I removed the local duplicated helpers and kept only Telegram-specific HTML-length enforcement around the shared function.

Verified with:
go test ./pkg/channels ./pkg/utils

huaaudio · 2026-02-19T10:15:09Z

Updated telegram.go to use the shared utility in pkg/utils (from #436) instead of duplicating the split logic. I removed the local duplicated helpers and kept only Telegram-specific HTML-length enforcement around the shared function.

Hi @jmahotiedu, I don't see the updated commit, can you check if it's been pushed? Also, I noticed the new network_guard.go util, as well as the scripts and helper functions in pkg/tools. Could you update the PR description to document those per the template? Thanks!

jmahotiedu · 2026-02-19T16:01:48Z

Hi @huaaudio, thanks for the catch. You were right, the update hadn’t been pushed yet.

I’ve now pushed commit a6c051e to fix/telegram-message-length-244 (telegram now uses the shared pkg/utils splitter from #436). I also updated the PR description per template to document network_guard.go and the related pkg/tools helper/script changes.

Verification run:
go test ./pkg/channels ./pkg/utils ./pkg/tools

nikolasdehor · 2026-02-23T00:38:18Z

This addresses the Telegram message-too-long bug (#212, #244, #449) but only handles Telegram-specific chunking. #527 implements universal chunking across all channels, which supersedes this and #476. Suggesting consolidation to #527.

jmahotiedu · 2026-02-23T18:09:20Z

@huaaudio @nikolasdehor @Andyi955 quick unblock proposal to get this finished and merged ASAP:

#251 is currently mergeable_state: dirty (conflicts with main), so it cannot be merged as-is.
#527 already targets universal chunking and appears to supersede the channel-specific path here.

Fastest path:

Merge #527 as the canonical chunking solution.
Close #251 as superseded after confirming any Telegram-specific HTML-length edge handling from this branch is covered in #527.
If desired, I can open/keep a separate focused PR for the unrelated tool-security hardening from this branch (filesystem/web/exec) so it can be reviewed independently.

If maintainers prefer keeping #251 instead, I can rebase it immediately and trim it to Telegram-only scope for quick review.

Andyi955 · 2026-02-23T23:56:51Z

@jmahotiedu Thanks for the tag and for looking into this!

To clarify, #527 (this branch) is the one that implements the universal chunking with full []rune support to guarantee perfect Emoji/CJK preservation. I noticed that older approaches (like #251) risk silently corrupting multibyte characters because they operate on raw byte offsets.

In this PR (#527), I have:

Unicode Safety: Operated strictly on []rune to ensure no emojis or CJK characters are split mid-byte.
Performance: Optimized chunking to a single-pass O(n) cursor-based offset, avoiding recursive overhead and making it highly efficient for long LLM outputs.
Reliability: Added robust table-driven tests in pkg/utils/message_test.go asserting Unicode boundaries, split-point detection, and code-block integrity.

Since this branch is clean and all tests are passing, I'd ask the maintainers to review #527 as the canonical solution.

alexhoshina · 2026-02-27T05:27:03Z

Already fixed in the refactor branch.

fix(telegram): split oversized outbound messages into chunks

3b4b6bf

jmahotiedu mentioned this pull request Feb 15, 2026

Telegram: message too long error on send #244

Closed

spacepirate0001 mentioned this pull request Feb 16, 2026

telegram - message is too long #212

Closed

Merge origin/main into fix/telegram-message-length-244

02291c7

huaaudio mentioned this pull request Feb 18, 2026

Refactor/base layer message split #436

Merged

5 tasks

nikolasdehor mentioned this pull request Feb 19, 2026

[BUG] Telegram Message Too Long on Long LLM Responses #449

Closed

refactor(telegram): use shared SplitMessage utility

a6c051e

nikolasdehor mentioned this pull request Feb 23, 2026

Add chunking on Telegram Msgs #476

Closed

10 tasks

alexhoshina mentioned this pull request Feb 23, 2026

[Refactor]: Channel System Refactoring / [Refactor]: Channel系统重构 #621

Closed

13 tasks

alexhoshina added this to the Refactor Channel milestone Feb 26, 2026

alexhoshina closed this Feb 27, 2026

github-actions bot mentioned this pull request Feb 28, 2026

🦞 OpenClaw 生态日报 2026-02-28 duanyytop/agents-radar#24

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Telegram send failures for oversized messages (#244)#251

Fix Telegram send failures for oversized messages (#244)#251
jmahotiedu wants to merge 4 commits intosipeed:mainfrom
jmahotiedu:fix/telegram-message-length-244

jmahotiedu commented Feb 15, 2026 •

edited

Loading

Uh oh!

Leeaandrob commented Feb 16, 2026

Uh oh!

Leeaandrob commented Feb 17, 2026

Uh oh!

jmahotiedu commented Feb 17, 2026

Uh oh!

jmahotiedu commented Feb 18, 2026

Uh oh!

huaaudio commented Feb 18, 2026

Uh oh!

jmahotiedu commented Feb 19, 2026

Uh oh!

huaaudio commented Feb 19, 2026 •

edited

Loading

Uh oh!

jmahotiedu commented Feb 19, 2026

Uh oh!

nikolasdehor commented Feb 23, 2026

Uh oh!

jmahotiedu commented Feb 23, 2026

Uh oh!

Andyi955 commented Feb 23, 2026 •

edited

Loading

Uh oh!

alexhoshina commented Feb 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

jmahotiedu commented Feb 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of Change

AI Code Generation

Linked Issue

Technical Context

Test Environment & Hardware

Proof of Work (Optional)

Checklist

Uh oh!

Leeaandrob commented Feb 16, 2026

Uh oh!

Leeaandrob commented Feb 17, 2026

Uh oh!

jmahotiedu commented Feb 17, 2026

Uh oh!

jmahotiedu commented Feb 18, 2026

Uh oh!

huaaudio commented Feb 18, 2026

Uh oh!

jmahotiedu commented Feb 19, 2026

Uh oh!

huaaudio commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jmahotiedu commented Feb 19, 2026

Uh oh!

nikolasdehor commented Feb 23, 2026

Uh oh!

jmahotiedu commented Feb 23, 2026

Uh oh!

Andyi955 commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexhoshina commented Feb 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jmahotiedu commented Feb 15, 2026 •

edited

Loading

huaaudio commented Feb 19, 2026 •

edited

Loading

Andyi955 commented Feb 23, 2026 •

edited

Loading