PR #227 Deep Review — @mattn

Clean, correct fix. The running bool field in MaixCamChannel shadowed the embedded BaseChannel.running, causing c.running (direct field access at line 73) to always read false while c.setRunning(true) set the base field.

Verification

• Checked out branch locally: fix-shadowing-running
• go vet ./pkg/channels/... — clean
• go test ./pkg/channels/... — all 15 tests passing
• Audited all 12 channel struct definitions — no other channel has this shadowing issue
• Confirmed c.running at maixcam.go:73 now correctly resolves to BaseChannel.running through Go embedding promotion

Impact Analysis

Before fix:

• c.setRunning(true) → sets BaseChannel.running = true
• c.IsRunning() → reads BaseChannel.running → true (correct)
• c.running (line 73) → reads MaixCamChannel.running → always false (shadowed!)

Effect: Connection accept errors were silently swallowed — the error log at line 73-77 never fired because the shadowed field was always false.

After fix: c.running correctly resolves to BaseChannel.running — error logging works.

Summary of Findings

LOW (Optional)

• L1: c.running at line 73 is the only direct field access across all 12 channels — all others use c.IsRunning(). Consider using c.IsRunning() for consistency (minor, not blocking).

POSITIVE

1. Correctly identifies and fixes Go struct embedding shadowing bug
2. Minimal 2-line change with zero risk of regression
3. No other channels are affected — confirmed by codebase audit

Verdict: APPROVE

Clean fix, zero risk. Ready to merge.