Skip to content

Add TupleOf type#1247

Merged
sindresorhus merged 5 commits intomainfrom
feat/expose-build-tuple-type
Sep 26, 2025
Merged

Add TupleOf type#1247
sindresorhus merged 5 commits intomainfrom
feat/expose-build-tuple-type

Conversation

@som-sm
Copy link
Collaborator

@som-sm som-sm commented Sep 25, 2025

Exposes the internal BuildTuple type.

@som-sm som-sm requested a review from Copilot September 25, 2025 18:41
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR exposes the internal BuildTuple type as a public API, moving it from the internal utilities to the main type collection.

  • Move BuildTuple from internal to public API
  • Update imports in test files to reference the new public location
  • Add comprehensive test coverage and documentation

Reviewed Changes

Copilot reviewed 5 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
test-d/split.ts Updates import to use public BuildTuple export
test-d/is-equal.ts Updates import to use public BuildTuple export
test-d/internal/build-tuple.ts Removes internal test file (deleted)
test-d/build-tuple.ts Adds comprehensive public API test coverage
readme.md Documents the new BuildTuple type in the API list

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@som-sm som-sm marked this pull request as ready for review September 25, 2025 18:51
@som-sm som-sm requested a review from sindresorhus September 25, 2025 18:51
@sindresorhus
Copy link
Owner

How about we name it just Tuple?

Alternatively TupleOf or FilledTuple.

@som-sm
Copy link
Collaborator Author

som-sm commented Sep 26, 2025

How about we name it just Tuple?

Alternatively TupleOf or FilledTuple.

I think TupleOf makes more sense as opposed to just Tuple because you can only create homogeneous tuples with this type.

@sindresorhus
Copy link
Owner

Ok. Let's go with TupleOf

@som-sm som-sm force-pushed the feat/expose-build-tuple-type branch from 56d3388 to 776cfec Compare September 26, 2025 05:34
@som-sm som-sm force-pushed the feat/expose-build-tuple-type branch from 776cfec to e851826 Compare September 26, 2025 05:41
@som-sm som-sm changed the title Add BuildTuple type Add TupleOf type Sep 26, 2025
@sindresorhus sindresorhus merged commit 7fb2f75 into main Sep 26, 2025
6 checks passed
@sindresorhus sindresorhus deleted the feat/expose-build-tuple-type branch September 26, 2025 06:46
som-sm added a commit that referenced this pull request Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants