Close readline in StdinDiscarder without changing stdin's pause state#210
Merged
sindresorhus merged 1 commit intosindresorhus:mainfrom Jun 26, 2022
Merged
Close readline in StdinDiscarder without changing stdin's pause state#210sindresorhus merged 1 commit intosindresorhus:mainfrom
StdinDiscarder without changing stdin's pause state#210sindresorhus merged 1 commit intosindresorhus:mainfrom
Conversation
sindresorhus
added a commit
that referenced
this pull request
Jun 27, 2022
This reverts commit 77ccc1e.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patches the close in
StdinDiscarderto keep stdin unpaused if it was already in that state.readline.close()has the undocumented side-effect of pausing the input stream, in this casestdin.Fixes #209.