Add preview mode#399

Merged

sindresorhus merged 26 commits into

sindresorhus:masterfrom

TiagoDanin-Forks:preview.mode

Feb 22, 2020

TiagoDanin commented May 3, 2019

Contributor

Fixes #391


          Add preview mode

f4f3bf2

TiagoDanin force-pushed the preview.mode branch from dda6e8a to f4f3bf2 Compare

May 3, 2019 23:42

itaisteinherz reviewed

View reviewed changes

source/cli.js Outdated

itaisteinherz reviewed

View reviewed changes

source/cli.js Outdated

itaisteinherz reviewed

View reviewed changes

source/index.js Outdated

itaisteinherz reviewed

View reviewed changes

source/index.js

itaisteinherz reviewed

View reviewed changes

source/index.js Outdated

TiagoDanin force-pushed the preview.mode branch from b9e46c0 to 8c599e5 Compare

May 4, 2019 14:13


          Improve preview mode

263cf7f

TiagoDanin force-pushed the preview.mode branch from 8c599e5 to 263cf7f Compare

May 4, 2019 14:14

itaisteinherz reviewed

View reviewed changes

source/index.js Outdated


          Show of commands in preview mode

3e15b54

TiagoDanin commented May 5, 2019

Contributor Author

itaisteinherz commented May 6, 2019

Collaborator

This looks good, though I'm still not sure what the best way to handle #399 (comment) is.

// cc @sindresorhus @SamVerschueren Would love to hear your opinions here.

itaisteinherz commented May 9, 2019

Collaborator

@TiagoDanin It would be great if you could investigate into #391 (comment).

sindresorhus commented Jun 29, 2019

Owner

This looks good, though I'm still not sure what the best way to handle #399 (comment) is.

The proposed solution there looks good to me.

@TiagoDanin It would be great if you could investigate into #391 (comment).

@TiagoDanin ⬆️

TiagoDanin added 2 commits

July 8, 2019 15:31


          Show correct package manager name

d379cea


          Merge branch 'master' into preview.mode

732b807

itaisteinherz approved these changes

View reviewed changes

itaisteinherz requested a review from sindresorhus

July 9, 2019 06:57

itaisteinherz commented Jul 9, 2019

Collaborator

One last thing I forgot - this needs to be document in readme.md, both in the Usage section as well as in the Why section.

TiagoDanin added 2 commits

July 22, 2019 12:37


          Documentation --preview

643e1ae


          Merge branch 'preview.mode' of github.com:TiagoDanin-Forks/np into pr…

194e908

…eview.mode

itaisteinherz reviewed

View reviewed changes

readme.md Outdated

itaisteinherz reviewed

View reviewed changes

readme.md Outdated

itaisteinherz reviewed

View reviewed changes

readme.md

TiagoDanin and others added 2 commits

August 3, 2019 17:55


          Update Why section in README

a59eda3

Co-Authored-By: Itai Steinherz <itaisteinherz@gmail.com>


          Fix, add two newlines before the next section

43eb8fe

itaisteinherz commented Aug 3, 2019

Collaborator

Waiting for @sindresorhus's final review before merging...

sindresorhus requested changes

View reviewed changes

source/index.js Outdated

source/index.js Outdated

readme.md Outdated

readme.md Outdated

chinesedfan suggested changes

View reviewed changes

chinesedfan left a comment

Contributor

Add some comments. Hope will help you.

source/index.js Outdated

source/index.js Outdated

source/index.js Outdated

source/index.js Outdated

source/npm/util.js Outdated

source/npm/util.js Outdated

TiagoDanin added 3 commits

January 11, 2020 08:00


          Improve preview mode description (by sindresorhus)

9d79205


          Improve preview mode show commands


          Revert show registry (3a2da0a)

6a48265

TiagoDanin force-pushed the preview.mode branch 6 times, most recently from 1f7285f to 7037382 Compare

January 11, 2020 16:07

TiagoDanin added 2 commits

January 11, 2020 13:08


          Merge branch 'master' into preview.mode

c5dbe96


          Remove flag --otp of enabling two-factor authentication in preview mode

4b954c3

TiagoDanin force-pushed the preview.mode branch from 71a076f to 6a48265 Compare

January 11, 2020 16:46

TiagoDanin mentioned this pull request

Show registry URL before publishing #485

Merged

chinesedfan suggested changes

View reviewed changes

chinesedfan left a comment

Contributor

You are almost there, except for little format problem.

source/index.js Outdated

source/index.js Outdated

source/index.js Outdated

source/npm/publish.js Outdated

sindresorhus commented Feb 8, 2020

Owner

Bump :)

TiagoDanin added 4 commits

February 8, 2020 19:06


          Show full command

9aad90b


          v5.2.2

a30621c


          Show full command


          Merge branch 'master' into preview.mode

ab5514c

TiagoDanin commented Feb 9, 2020

Contributor Author

Sorry for the delayed response.

TiagoDanin requested review from chinesedfan, itaisteinherz and sindresorhus

February 9, 2020 01:23

chinesedfan approved these changes

View reviewed changes

itaisteinherz reviewed

View reviewed changes

source/npm/publish.js Outdated

chinesedfan mentioned this pull request

Fix 2FA prompt when the package exists #505

Merged

sindresorhus added 2 commits

February 22, 2020 15:37


          Update publish.js

c70fa38


          Update index.js

268aeb4

sindresorhus merged commit 5f52e81 into sindresorhus:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet