Skip to content

[jasmine] Add throwUnless and throwUnlessAsync globals#335

Merged
sindresorhus merged 1 commit intosindresorhus:mainfrom
ej612:main
Jan 27, 2026
Merged

[jasmine] Add throwUnless and throwUnlessAsync globals#335
sindresorhus merged 1 commit intosindresorhus:mainfrom
ej612:main

Conversation

@ej612
Copy link
Contributor

@ej612 ej612 commented Jan 27, 2026

Add jasmine's throwUnless & throwUnlessAsync globals that were added with v5.1.0.

jasmine 5.1.0 added the throwUnless & throwUnlessAsync globals, but they were never added to this package.
Copy link
Collaborator

@fisker fisker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sindresorhus sindresorhus merged commit f195378 into sindresorhus:main Jan 27, 2026
5 checks passed
@sindresorhus
Copy link
Owner

@fisker This PR edited the JSON instead of the data. Would have been nice to have a CI check for that.

@fisker
Copy link
Collaborator

fisker commented Feb 1, 2026

Strange, we already have test for it

globals/test.mjs

Lines 102 to 105 in 8176ac7

t.deepEqual(
jsData,
globals,
);

@fisker
Copy link
Collaborator

fisker commented Feb 1, 2026

And it works on local,

image image

@fisker
Copy link
Collaborator

fisker commented Feb 1, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants