Fixes argument parsing for escaped newlines#1176
Merged
ehmicky merged 4 commits intosindresorhus:mainfrom Dec 7, 2024
Merged
Conversation
Contributor
Author
|
I'm not sure if I have this fix right, even though the test passes. |
Collaborator
|
Hi @aarondandy, Thanks, but this should not be needed due to #1175 (comment) |
aarondandy
commented
Dec 6, 2024
Contributor
Author
|
Even though this is closed, I still think this indicates a bug in Edit: I'm not longer confident in my unconfidence, see: #1175 (comment) |
aarondandy
commented
Dec 6, 2024
aarondandy
commented
Dec 6, 2024
Collaborator
|
Let's continue this discussion on #1175. |
Collaborator
|
This looks good (except for a few small things), thanks for the PR. 👍 |
ehmicky
reviewed
Dec 6, 2024
ehmicky
reviewed
Dec 7, 2024
ehmicky
approved these changes
Dec 7, 2024
Collaborator
|
Looks good to me. Thanks again @aarondandy. @sindresorhus Is this good to merge? |
sindresorhus
approved these changes
Dec 7, 2024
renovate bot
added a commit
to mmkal/eslint-plugin-mmkal
that referenced
this pull request
Dec 8, 2024
##### [v9.5.2](https://github.com/sindresorhus/execa/releases/tag/v9.5.2) #### Bug fixes - Fix escaping newlines inside template strings. Thanks [@aarondandy](https://github.com/aarondandy)! ([#1176](sindresorhus/execa#1176))
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Dec 8, 2024
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | execa | 9.5.1 | 9.5.2 | ## [v9.5.2](https://github.com/sindresorhus/execa/releases/tag/v9.5.2) #### Bug fixes - Fix escaping newlines inside template strings. Thanks [@aarondandy](https://github.com/aarondandy)! ([#1176](sindresorhus/execa#1176))
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Dec 10, 2024
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | execa | 9.5.1 | 9.5.2 | ## [v9.5.2](https://github.com/sindresorhus/execa/releases/tag/v9.5.2) #### Bug fixes - Fix escaping newlines inside template strings. Thanks [@aarondandy](https://github.com/aarondandy)! ([#1176](sindresorhus/execa#1176))
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Dec 11, 2024
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | execa | 9.5.1 | 9.5.2 | ## [v9.5.2](https://github.com/sindresorhus/execa/releases/tag/v9.5.2) #### Bug fixes - Fix escaping newlines inside template strings. Thanks [@aarondandy](https://github.com/aarondandy)! ([#1176](sindresorhus/execa#1176))
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Dec 12, 2024
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | execa | 9.5.1 | 9.5.2 | ## [v9.5.2](https://github.com/sindresorhus/execa/releases/tag/v9.5.2) #### Bug fixes - Fix escaping newlines inside template strings. Thanks [@aarondandy](https://github.com/aarondandy)! ([#1176](sindresorhus/execa#1176))
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Dec 14, 2024
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | execa | 9.5.1 | 9.5.2 | ## [v9.5.2](https://github.com/sindresorhus/execa/releases/tag/v9.5.2) #### Bug fixes - Fix escaping newlines inside template strings. Thanks [@aarondandy](https://github.com/aarondandy)! ([#1176](sindresorhus/execa#1176))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1175.
Trying to handle escaped line breaks in template strings.