Merged
Conversation
monkeyiq
reviewed
Mar 1, 2026
monkeyiq
reviewed
Mar 1, 2026
d380e5a to
e0d2141
Compare
I also kept a reference to the errata 05 page/line here in a comment
As the default was true for this before it is now that way again. If the format is NAMEID_TRANSIENT it will be set to respect the Errata 05.
monkeyiq
added a commit
that referenced
this pull request
Mar 5, 2026
* Bugfix: don't set illegal combination of AllowCreate/Format * Force allowCreate to false if format is TRANSIENT I also kept a reference to the errata 05 page/line here in a comment * allowCreate is true by default and contained for TRANSIENT As the default was true for this before it is now that way again. If the format is NAMEID_TRANSIENT it will be set to respect the Errata 05. * The persistent default is back to having allowCreate=true --------- Co-authored-by: Ben Martin <monkeyiq@users.sourceforge.net>
tvdijen
added a commit
that referenced
this pull request
Mar 5, 2026
* Bugfix: don't set illegal combination of AllowCreate/Format * Force allowCreate to false if format is TRANSIENT I also kept a reference to the errata 05 page/line here in a comment * allowCreate is true by default and contained for TRANSIENT As the default was true for this before it is now that way again. If the format is NAMEID_TRANSIENT it will be set to respect the Errata 05. * The persistent default is back to having allowCreate=true --------- Co-authored-by: Ben Martin <monkeyiq@users.sourceforge.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2602
@ghalse Your review is also appreciated!