fix for attributes.po translations#2576
Merged
monkeyiq merged 2 commits intosimplesamlphp:simplesamlphp-2.4from Dec 11, 2025
Merged
fix for attributes.po translations#2576monkeyiq merged 2 commits intosimplesamlphp:simplesamlphp-2.4from
monkeyiq merged 2 commits intosimplesamlphp:simplesamlphp-2.4from
Conversation
Contributor
Author
|
OK, so I have to look into ExceptionTest I think. |
Contributor
Author
|
That seems to come down to the new |
monkeyiq
added a commit
that referenced
this pull request
Dec 11, 2025
* A 2.4 PR of 2575 to see what the CI makes of it in that env. #2575 * it seems that the number of attempted paths in included in the count
monkeyiq
added a commit
that referenced
this pull request
Dec 11, 2025
* A 2.4 PR of 2575 to see what the CI makes of it in that env. #2575 * it seems that the number of attempted paths in included in the count
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As this now passes I will merge this and cherry pick forwards from here.
Translations from attributes.po are implicitly put into the attributes domain. The code looking for them was looking in the empty domain still. Also addAttributeDomains is included now to explicitly make sure they are loaded.
This was raised in
#2572
#2575