Skip to content

store.redis.tls should apply to sentinels#2557

Merged
tvdijen merged 1 commit intosimplesamlphp:masterfrom
ghalse:patch-redis-tls
Nov 17, 2025
Merged

store.redis.tls should apply to sentinels#2557
tvdijen merged 1 commit intosimplesamlphp:masterfrom
ghalse:patch-redis-tls

Conversation

@ghalse
Copy link
Copy Markdown
Contributor

@ghalse ghalse commented Nov 17, 2025

The documentation in config.php.dist says

Communicate with Redis over a secure connection instead of plain TCP.

This setting affects both single host connections as
well as Sentinel mode.

However, that's not what actually happens. We can connect to TLS-enabled sentinels using tls://, but
if they return a TLS-enabled master, then we still try tcp:// rather than tls:// when connecting. That causes an exception to be thrown:

Caused by: Predis\Connection\ConnectionException: Error while reading line from the server. [tcp://172.16.2.104:6379]

This completes the configuration started in #1828 by making it possible to use a wholly TLS-enabled Redis setup with sentinels.

@tvdijen tvdijen merged commit f288c76 into simplesamlphp:master Nov 17, 2025
13 of 21 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants