Update FontAwesome icon names#2509
Merged
tvdijen merged 1 commit intosimplesamlphp:masterfrom Sep 5, 2025
Merged
Conversation
Contributor
|
For SSP 2.4 I see Font Awesome Free 6.7.1 in the base assets of my install. I am happy to move to the version 6+ names for 2.4+ |
Contributor
|
As you say, |
monkeyiq
approved these changes
Sep 4, 2025
Contributor
|
Looking at the support page this seems like something to be picked back into ssp 2.3 (assuming it is on the same fa). At least 2.4 is on fa 6.7.1 here. |
tvdijen
pushed a commit
that referenced
this pull request
Sep 5, 2025
tvdijen
pushed a commit
that referenced
this pull request
Sep 5, 2025
tvdijen
pushed a commit
that referenced
this pull request
Sep 5, 2025
tvdijen
pushed a commit
that referenced
this pull request
Sep 5, 2025
tvdijen
pushed a commit
that referenced
this pull request
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few of the Twig templates still have old FontAwesome 4 icon names. While these are mostly backwards compatible still, at least one used in the logout-iframe.twig has gone completely (circle-o-notch) resulting in a broken display.
This updates the names to the version 6+ naming per https://docs.fontawesome.com/v6/web/setup/upgrade/whats-changed#icons-renamed-in-version-6