Allow "Secure" cookie attribute via HTTP on localhost#2483
Merged
tvdijen merged 3 commits intosimplesamlphp:masterfrom Jul 10, 2025
Merged
Allow "Secure" cookie attribute via HTTP on localhost#2483tvdijen merged 3 commits intosimplesamlphp:masterfrom
tvdijen merged 3 commits intosimplesamlphp:masterfrom
Conversation
Member
|
I'd say this includes @edit: Grok thinks this only applies to |
tvdijen
added a commit
that referenced
this pull request
Jul 10, 2025
* allow secure cookie on localhost * allow ipv4 & ipv6 loopback addresses * Remove excess parenthesis --------- Co-authored-by: Sebastiano Degan <sebastiano@localhost.localdomain> Co-authored-by: Tim van Dijen <tvdijen@gmail.com>
tvdijen
added a commit
that referenced
this pull request
Jul 10, 2025
* allow secure cookie on localhost * allow ipv4 & ipv6 loopback addresses * Remove excess parenthesis --------- Co-authored-by: Sebastiano Degan <sebastiano@localhost.localdomain> Co-authored-by: Tim van Dijen <tvdijen@gmail.com>
Member
|
Backported into 2.4 and 2.3 release-branch. To be released in a next dot-release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to Mozilla Docs,
Secureattribute should be allowed on localhost even if HTTP is used.It makes testing a little easier.
My only doubt is about "localhost" vs "127.0.0.1" should both be allowed or only the former?