Fix auth state AuthnInstant#2478
Merged
tvdijen merged 2 commits intosimplesamlphp:masterfrom Jun 30, 2025
Merged
Conversation
The time of authentication is handled in the field 'AuthnInstant' and should be persisted in the state in case it is needed.
Member
|
Constants for keys certainly is a good approach! I'll create an issue for this. |
tvdijen
pushed a commit
that referenced
this pull request
Jun 30, 2025
* Fix persistence for AuthnInstant data The time of authentication is handled in the field 'AuthnInstant' and should be persisted in the state in case it is needed.
tvdijen
pushed a commit
that referenced
this pull request
Jun 30, 2025
* Fix persistence for AuthnInstant data The time of authentication is handled in the field 'AuthnInstant' and should be persisted in the state in case it is needed.
tvdijen
pushed a commit
that referenced
this pull request
Jun 30, 2025
* Fix persistence for AuthnInstant data The time of authentication is handled in the field 'AuthnInstant' and should be persisted in the state in case it is needed.
tvdijen
pushed a commit
that referenced
this pull request
Jun 30, 2025
* Fix persistence for AuthnInstant data The time of authentication is handled in the field 'AuthnInstant' and should be persisted in the state in case it is needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The time of authentication is handled in the field 'AuthnInstant' and should be persisted in the state in case it is needed.
This PR fixes a typo in a key reference for the field 'AuthnInstant'.
Since these kind of typos can happen quite unnoticed, we should consider using constants to refer to array keys.
Any thoughts about it?