i18n allow the substitution of SPNAME and other TWIG variables#2409
Merged
monkeyiq merged 2 commits intosimplesamlphp:simplesamlphp-2.3from Mar 20, 2025
Merged
Conversation
This was raised with solution at simplesamlphp#2407 I have added a comment to the method doc block to warn about these extra parameters which are expected in some contexts
monkeyiq
added a commit
that referenced
this pull request
Mar 20, 2025
* i18n allow the substitution of SPNAME and other TWIG variables This was raised with solution at #2407 I have added a comment to the method doc block to warn about these extra parameters which are expected in some contexts * leave that blank line alone
monkeyiq
added a commit
that referenced
this pull request
Mar 20, 2025
* i18n allow the substitution of SPNAME and other TWIG variables This was raised with solution at #2407 I have added a comment to the method doc block to warn about these extra parameters which are expected in some contexts * leave that blank line alone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was raised with solution at
#2407
I have added a comment to the method doc block to warn about these extra parameters which are expected in some contexts