Move the endpoint breaking change to the "BC break" section#2265
Merged
tvdijen merged 1 commit intosimplesamlphp:masterfrom Oct 7, 2024
briskt:patch-1
Merged
Move the endpoint breaking change to the "BC break" section#2265tvdijen merged 1 commit intosimplesamlphp:masterfrom briskt:patch-1
tvdijen merged 1 commit intosimplesamlphp:masterfrom
briskt:patch-1
Conversation
tvdijen
pushed a commit
that referenced
this pull request
Oct 7, 2024
tvdijen
pushed a commit
that referenced
this pull request
Oct 7, 2024
monkeyiq
added a commit
that referenced
this pull request
Oct 31, 2024
…osted IdPs (#2270) * docs: make a link to the release process (#2262) * docs: make a link to the release process * lint the things that do not matter * docs: update SP example to use the non string endpoint format (#2263) * docs: update SP example to new non string endpoint format * add the certificate back there * docs remove that double instance (#2264) * Move the endpoint breaking change to the "BC break" section (#2265) * Make it easier to override metadata storage test configuration * Enable overriding properties for particular IdP in case of multiple hosted IdPs * Include entity ID when resolving endpoints from metadata * Fix phpcs errors * Fix phpcs errors --------- Co-authored-by: monkeyiq <monkeyiq@gmail.com> Co-authored-by: briskt <3172830+briskt@users.noreply.github.com> Co-authored-by: Marko Ivančić <marko.ivancic@srce.hr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realize the endpoint format change may have been omitted from the breaking change section because of the "9-year" deprecation. That, however, does not change the fact that it is actually a breaking change. This was also identified as a breaking change in the commit message.