plain text admin password follow-up#2223
Merged
monkeyiq merged 1 commit intosimplesamlphp:simplesamlphp-2.3from Aug 30, 2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up to #2222.
I added a new
deprecatedmethod to Logger. I think this is useful as there are many parts of the code that have@depcreatedin comments. If that code is wanting to issue a warning then using a specific logger method signals exactly what the intent is.The upgrade-notes-2.3.md are a little more complex but I tried to make the 2.3.1+ case the default and read easily for folks who are upgrading from 2.2 to 2.3.1+. I notice that the changelog is already updated 023688b to reflect the changes in #2222
We could refine the
Logger::deprecatedto have it's own DEPRECATED=8 and so on if we like. Having it has a WARNING behind the API call is a good start.