Skip to content

Fix config.php.dist coding standards#2056

Merged
tvdijen merged 2 commits intosimplesamlphp:masterfrom
ronaldmulero:coding-standards
Apr 16, 2024
Merged

Fix config.php.dist coding standards#2056
tvdijen merged 2 commits intosimplesamlphp:masterfrom
ronaldmulero:coding-standards

Conversation

@ronaldmulero
Copy link
Copy Markdown
Contributor

2 small fixes to config/config.php.dist so that it complies with PSR12, as defined in phpcs.xml.

  1. Comment line 22 of phpcs.xml, to avoid phpcs failure.

  2. Run the standards check:

phpcs --standard=phpcs.xml --extensions='dist' config/config.php.dist
  1. Result:
-----------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------
  61 | ERROR | [x] Whitespace found at end of line
 278 | ERROR | [ ] Line exceeds maximum limit of 130 characters; contains 214 characters
-----------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------
  1. Note: the fix for line 278 is copied from
    'Content-Security-Policy' =>

@tvdijen tvdijen merged commit 94c8f22 into simplesamlphp:master Apr 16, 2024
@tvdijen
Copy link
Copy Markdown
Member

tvdijen commented Apr 16, 2024

Thanks @ronaldmulero !

cicnavi pushed a commit to cicnavi/simplesamlphp that referenced this pull request May 24, 2024
* Fix config.php.dist coding standards

* Remove unused use-statements

---------

Co-authored-by: Tim van Dijen <tvdijen@gmail.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants