Correct host in generated URLS for IdPs with 'host' config in admin/federation#1781
Merged
Correct host in generated URLS for IdPs with 'host' config in admin/federation#1781
Conversation
…ederation It gets quite fiddly to get this right. The actual metadata (hosted on the `host` itself) is alreafy correct because the URL generator uses the 'current' entity metadata and current URL. The admin interface of course presents all entities in one page and hence cannot rely on the current URL. Therefore we need to override the url host for this specific display case. Closes: #1774
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1781 +/- ##
============================================
+ Coverage 45.48% 45.52% +0.04%
- Complexity 3692 3696 +4
============================================
Files 158 158
Lines 12292 12300 +8
============================================
+ Hits 5591 5600 +9
+ Misses 6701 6700 -1 |
tvdijen
approved these changes
Mar 3, 2023
tvdijen
pushed a commit
that referenced
this pull request
Mar 21, 2023
…ederation (#1781) It gets quite fiddly to get this right. The actual metadata (hosted on the `host` itself) is alreafy correct because the URL generator uses the 'current' entity metadata and current URL. The admin interface of course presents all entities in one page and hence cannot rely on the current URL. Therefore we need to override the url host for this specific display case. Closes: #1774
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It gets quite fiddly to get this right. The actual metadata (hosted on the
hostitself) is alreafy correct because the URL generator uses the 'current' entity metadata and current URL. The admin interface of course presents all entities in one page and hence cannot rely on the current URL. Therefore we need to override the url host for this specific display case.Closes: #1774