Merged
Conversation
PHPStan has improved a lot since version 1.12 used by SimplePie until now. Take advantage of explicit PHPStan phpVersion range. Define explicit range of minimum and maximum PHP version supported. Useful e.g. for function signatures, which have changed over time https://phpstan.org/config-reference#phpversion Do not run PHPStan for PHP < 7.4 but the tests are covered by phpVersion min, so it is actually enough to run PHPStan once on any supported PHP version. Cannot support PHPUnit >= 10 at the same time as PHP 7.2.
Keep change for another PR
Co-authored-by: Jan Tojnar <jtojnar@gmail.com>
Since simplepie#939 has been waiting for a long time, here is a PR still using PHPStan 1 (so it should be easier to merge), but fixing many problems caught by PHPStan 2.
Art4
approved these changes
Jan 18, 2026
Member
|
Thanks. |
Alkarex
added a commit
to FreshRSS/simplepie
that referenced
this pull request
Jan 18, 2026
Alkarex
added a commit
to Alkarex/FreshRSS
that referenced
this pull request
Jan 18, 2026
Alkarex
added a commit
to FreshRSS/FreshRSS
that referenced
this pull request
Jan 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #939 has been waiting for a long time, here is a PR still using PHPStan 1 (so it should be easier to merge), but fixing many problems caught by PHPStan 2.
In other words, this PR is a subset of #939