Skip to content

demo: Clean up a bit#948

Merged
jtojnar merged 6 commits intomasterfrom
wip/jtojnar/demo-cleanup
Sep 30, 2025
Merged

demo: Clean up a bit#948
jtojnar merged 6 commits intomasterfrom
wip/jtojnar/demo-cleanup

Conversation

@jtojnar
Copy link
Member

@jtojnar jtojnar commented Sep 29, 2025 •
edited
Loading

  • demo: Remove magic_quotes_gpc workaround
  • demo: Use numeric microtime

Thanks to @Alkarex for the above.

  • deḿo: Format with PHP-CS-Fixer
  • demo: Remove siFR
  • demo: Remove dead test tool link
  • demo: Disable multifeed support

@jtojnar jtojnar requested a review from Art4 September 29, 2025 10:22
@jtojnar jtojnar mentioned this pull request Sep 29, 2025
Open
@Alkarex
Copy link
Contributor

Alkarex commented Sep 29, 2025

Thanks to @Alkarex for the above.

:-)

Just FYI, it does not matter here, but if you were to want to credit someone, the approach recognised by GitHub is a syntax like the following in a commit message:

Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>

Example: 1374b15

Art4
Art4 requested changes Sep 29, 2025
View reviewed changes
Copy link
Contributor

@Art4 Art4 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a small improvement.

Alkarex and others added 6 commits September 29, 2025 23:35
@Alkarex @jtojnar
demo: Remove magic_quotes_gpc workaround
9b788a3 
The implementation of magic_quotes_gpc was removed in PHP 5.4 and the function for checking was dropped in PHP 8.0:
https://www.php.net/manual/en/function.get-magic-quotes-gpc.php
@Alkarex @jtojnar
demo: Use numeric microtime
de47e5d 
This will slightly simplify the code.
@jtojnar
demo: Format with PHP-CS-Fixer
e4e557b
@jtojnar
demo: Remove siFR
28dff02 
It is an ancient technology for using custom fonts based on Flash.
It will not work in any modern browser.
@jtojnar
demo: Remove dead test tool link
6c1354c 
The test runner was removed in 0fcde72.
@jtojnar
demo: Disable multifeed support
c2cf2cf 
Multifeed has been deprecated since ff1b513.
@jtojnar jtojnar force-pushed the wip/jtojnar/demo-cleanup branch from 5d0884b to c2cf2cf Compare September 29, 2025 21:36
@jtojnar jtojnar requested a review from Art4 September 29, 2025 21:37
@jtojnar
Copy link
Member Author

jtojnar commented Sep 29, 2025

Just FYI, it does not matter here, but if you were to want to credit someone, the approach recognised by GitHub is a syntax like the following in a commit message:

I just cherry-picked your commit and dropped the unrelated parts so the Author field containing your name is preserved.

@Alkarex
Copy link
Contributor

Alkarex commented Sep 29, 2025

I just cherry-picked your commit and dropped the unrelated parts so the Author field containing your name is preserved.

Ah indeed, I had not noticed. Then this is done automatically :-)

@Art4 Art4 added this to the 1.10.0 milestone Sep 30, 2025
@jtojnar jtojnar merged commit bb09610 into master Sep 30, 2025
20 checks passed
@jtojnar jtojnar deleted the wip/jtojnar/demo-cleanup branch September 30, 2025 08:32
This was referenced Sep 30, 2025
Closed
Merged
Alkarex added a commit to FreshRSS/simplepie that referenced this pull request Sep 30, 2025
@Alkarex
Merge pull request #58 from FreshRSS/merge-upstream
d5c62f3 
Including:
* simplepie#943
* simplepie#945
* simplepie#948
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Art4 Art4 Art4 approved these changes

+1 more reviewer

@Alkarex Alkarex Alkarex left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/XL

Projects

None yet

Milestone

1.10.0

Development

Successfully merging this pull request may close these issues.

3 participants

@jtojnar @Alkarex @Art4