Normalize encoding uppercase#936
Merged
jtojnar merged 2 commits intosimplepie:masterfrom Sep 14, 2025
Merged
Conversation
SimplePie uses uppercase for encoding everywhere, except in the parser, which makes `array_unique()` to fail to do its job when the document declares `utf-8` and we already have `UTF-8` in the list: https://github.com/simplepie/simplepie/blob/1838b28db27ee206e0c2cf183f7b2af75abed143/src/SimplePie.php#L1780-L1785
Member
|
Thanks. |
Alkarex
added a commit
to Alkarex/FreshRSS
that referenced
this pull request
Sep 15, 2025
Alkarex
added a commit
to FreshRSS/FreshRSS
that referenced
this pull request
Sep 15, 2025
* simplepie/simplepie#936 (Normalize encoding uppercase)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SimplePie uses uppercase for encoding everywhere, except in the parser, which makes
array_unique()to fail to do its job when the document declaresutf-8and we already haveUTF-8in the list:simplepie/src/SimplePie.php
Lines 1780 to 1785 in 1838b28