No URL Decode for enclosure links#768
Merged
mblaney merged 6 commits intosimplepie:masterfrom Jan 12, 2023
Merged
Conversation
This line was introduced in simplepie@8a5f601#diff-a710c236cc7775672edbe5840d8fb96b0e91b0d56eff709f6eace2da47c1fe43R349-R359 Seems to be a similar error than simplepie@efb1d8e Having an `urldecode` returns some potentially invalid URLs, while SimplePie does not do that for other returned URLs Downstream PR FreshRSS/FreshRSS#4944 P.S. There are a few other bugs related to enclosure links, and I will try to address some of them in distinct PRs.
Alkarex
added a commit
to FreshRSS/simplepie
that referenced
this pull request
Dec 31, 2022
SimplePie only returned the first enclosure when using the RSS 2.0 syntax for enclosures, instead of returning them all. Please merge simplepie#768 first. Downtream PR: FreshRSS/FreshRSS#4944
Alkarex
added a commit
to FreshRSS/simplepie
that referenced
this pull request
Dec 31, 2022
Add missing sanitize and absolute_url on thumbnail URL. SimplePie normally sanitizes all URLs, but the thumbnail URL was not processed. Related to simplepie#768 Downstream PR FreshRSS/FreshRSS#4944
Merged
Art4
approved these changes
Dec 31, 2022
Member
It has actually been introduced in 4bbd7ea – one has to jump a bit since git blame is not perfect. Could you please update the commit message? |
jtojnar
reviewed
Jan 1, 2023
Co-authored-by: Jan Tojnar <jtojnar@gmail.com>
mblaney
pushed a commit
that referenced
this pull request
Jan 12, 2023
* Sanitize thumbnail URL Add missing sanitize and absolute_url on thumbnail URL. SimplePie normally sanitizes all URLs, but the thumbnail URL was not processed. Related to #768 Downstream PR FreshRSS/FreshRSS#4944 * Update tests syntax
Art4
added a commit
to Art4/simplepie
that referenced
this pull request
Jan 12, 2023
mblaney
pushed a commit
that referenced
this pull request
Jan 19, 2023
* No URL Decode for enclosure links This line was introduced in 8a5f601#diff-a710c236cc7775672edbe5840d8fb96b0e91b0d56eff709f6eace2da47c1fe43R349-R359 Seems to be a similar error than efb1d8e Having an `urldecode` returns some potentially invalid URLs, while SimplePie does not do that for other returned URLs Downstream PR FreshRSS/FreshRSS#4944 P.S. There are a few other bugs related to enclosure links, and I will try to address some of them in distinct PRs. * Add tests * Simplify tests * Fix case of multiple RSS2.0 enclosures SimplePie only returned the first enclosure when using the RSS 2.0 syntax for enclosures, instead of returning them all. Please merge #768 first. Downtream PR: FreshRSS/FreshRSS#4944 * Whitespace * PHP 7.2 compat * PHP 7.2 compat * Update tests/Unit/EnclosureTest.php Co-authored-by: Artur Weigandt <Art4@users.noreply.github.com> * Update tests/Unit/EnclosureTest.php Co-authored-by: Jan Tojnar <jtojnar@gmail.com> * Update src/Item.php Co-authored-by: Jan Tojnar <jtojnar@gmail.com> * Update tests syntax Co-authored-by: Artur Weigandt <Art4@users.noreply.github.com> Co-authored-by: Jan Tojnar <jtojnar@gmail.com>
mblaney
pushed a commit
that referenced
this pull request
Jan 20, 2023
* bump version to 1.8.0 * Update CHANGELOG.md * Fix version tags in deprecated messages * fix version in old deprecation messages * Fix typo see comment from @jtojnar in #752 * Add comment for DataCache interface see comment from @jtojnar in #752 * Update CHANGELOG.md for #760, #764 and #765 * Update CHANGELOG.md for #762, #767 and #763 * Update CHANGELOG.md for #768 and #770 * Update release date * Update CHANGELOG.md for #769 and #771 * Update CHANGELOG.md for #766
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having an
urldecodereturns some potentially invalid URLs for enclosures, while SimplePie does not do that for other returned URLs.Seems to be a similar error than efb1d8e
This line was introduced in 4bbd7ea
Downstream PR FreshRSS/FreshRSS#4944
P.S. There are a few other bugs related to enclosure links, and I will try to address some of them in distinct PRs.