Removed trailing and leading whitespaces#445
Merged
mblaney merged 1 commit intosimplepie:masterfrom May 15, 2016
Merged
Conversation
…dom/xml reader will throw an error is there's a space at the beginning.
Alkarex
added a commit
to FreshRSS/simplepie
that referenced
this pull request
Jun 24, 2025
Example of valid feed not working in SimplePie: https://haveibeenpwned.com/feed/breaches/ Regression due to simplepie#445 The final character `>` of a feed is encoded as `3E00` in UTF-16LE, so calling `trim()` was removing the `\x00`, breaking the multibyte encoding and making the feed invalid. Downstream issue FreshRSS/FreshRSS#7690
Contributor
|
This introduced a regression, breaking UTF-16LE and UTF-32BE encodings. |
jtojnar
pushed a commit
that referenced
this pull request
Jun 25, 2025
Example of valid feed not working in SimplePie: https://haveibeenpwned.com/feed/breaches/ Regression due to #445 The final character `>` of a feed is encoded as `3E 00` in UTF-16LE, so calling `trim()` was removing the `\x00`, breaking the multibyte encoding and making the feed invalid. Downstream issue FreshRSS/FreshRSS#7690
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed trailing and leading whitespaces on XML feed
content because dom/xml reader will throw an error is
there's a space at the beginning.
See issue:
http://screencast.com/t/rOuj1W3z