Closed
Conversation
…e behaviour of a sometimes-empty commit.tree.blobs and avoids the filtered comprehension.
…a file in iso-8859-1/latin-1
Author
|
FWIW: |
Owner
|
Sorry for not looking at this sooner! I'm not keen on |
Author
|
I honestly forget how this works. If you're happy with the other method, so am I. (-: |
|
Can we merge this? I also encountered this issue and didn't see this PR so ended up with a similar fix but this wouldv'e saved me some time! |
simonw
pushed a commit
that referenced
this pull request
Dec 21, 2025
This addresses the encoding issue reported in PR #52 where CSV files encoded in Latin-1/ISO-8859-1 couldn't be processed because the default encoding was hardcoded as UTF-8. Changes: - Add --encoding option to specify character encoding for CSV files - Modify build_csv_convert_string() to accept and use the encoding parameter - Add validation that --encoding requires --csv or --dialect - Add comprehensive tests for Latin-1, ISO-8859-1, and UTF-16 encodings
simonw
pushed a commit
that referenced
this pull request
Dec 21, 2025
This addresses the encoding issue reported in PR #52 where CSV files encoded in Latin-1/ISO-8859-1 couldn't be processed because the default encoding was hardcoded as UTF-8. Changes: - Add --encoding option to specify character encoding for CSV files - Modify build_csv_convert_string() to accept and use the encoding parameter - Add validation that --encoding requires --csv or --dialect - Add comprehensive tests for Latin-1, ISO-8859-1, and UTF-16 encodings - Document --encoding option in README
simonw
added a commit
that referenced
this pull request
Dec 21, 2025
This addresses the encoding issue reported in PR #52 where CSV files encoded in Latin-1/ISO-8859-1 couldn't be processed because the default encoding was hardcoded as UTF-8. Changes: - Add --encoding option to specify character encoding for CSV files - Modify build_csv_convert_string() to accept and use the encoding parameter - Add validation that --encoding requires --csv or --dialect - Add comprehensive tests for Latin-1, ISO-8859-1, and UTF-16 encodings - Document --encoding option in README Co-authored-by: Claude <noreply@anthropic.com>
Owner
|
Now fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussed in #50
I think I had two problems here, but they might be related:
commit.tree.blobswas[]here. I changed this to use thetree['filename']notation--re-encodeTests pass.