Use separate JS variable to store file, Fixes drag + drop#32
Merged
simonw merged 1 commit intosimonw:mainfrom Jun 28, 2023
Merged
Use separate JS variable to store file, Fixes drag + drop#32simonw merged 1 commit intosimonw:mainfrom
simonw merged 1 commit intosimonw:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Click + upload works file, but drag + dropping a file does not.
I believe it's because of this line:
datasette-upload-csvs/datasette_upload_csvs/templates/upload_csv.html
Line 134 in 0636bd0
The
.filesproperty is immutable, so setting.files[0] = somethingdoesn't work. For files that were uploaded manually, this worked fine becauseinputFiles.files[0]was set already. But when a file was dragged + dropped, settinginputFiles.files[0]toe.dataTransfer.files[0]wouldn't work.So, I pulled
currentFileas a separate JS variable and use that as the source-of-truth.Screen.Recording.2023-06-27.at.1.19.53.PM.mov