Use inspect-file, if possible, for total row count#666
Merged
simonw merged 1 commit intosimonw:masterfrom Feb 25, 2020
kevindkeogh:faster-table-count
Merged
Use inspect-file, if possible, for total row count#666simonw merged 1 commit intosimonw:masterfrom kevindkeogh:faster-table-count
simonw merged 1 commit intosimonw:masterfrom
kevindkeogh:faster-table-count
Conversation
Owner
|
This is a smart optimization. I'd like to add a test for it, since the logic is a tiny bit more complex. |
For large tables, counting the number of rows in the table can take a signficant amount of time. Instead, where an inspect-file is provided for an immutable database, look up the row-count for a plain count(*).
Contributor
Author
|
It was very helpful for me, using it for a 15M row table. Added a test, happy to amend though! |
Owner
|
This is great, thanks! |
simonw
pushed a commit
that referenced
this pull request
Mar 26, 2020
For large tables, counting the number of rows in the table can take a significant amount of time. Instead, where an inspect-file is provided for an immutable database, look up the row-count for a plain count(*). Thanks, @kevindkeogh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For large tables, counting the number of rows in the table can take a
signficant amount of time. Instead, where an inspect-file is provided
for an immutable database, look up the row-count for a plain count(*).