skip over "queries" blocks when processing database-level metadata items#2386
Merged
simonw merged 3 commits intosimonw:mainfrom Aug 16, 2024
Merged
skip over "queries" blocks when processing database-level metadata items#2386simonw merged 3 commits intosimonw:mainfrom
simonw merged 3 commits intosimonw:mainfrom
Conversation
Owner
|
We need a test for this. Do we need to do anything else before we land it? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2386 +/- ##
==========================================
- Coverage 92.55% 92.54% -0.02%
==========================================
Files 41 41
Lines 6410 6421 +11
==========================================
+ Hits 5933 5942 +9
- Misses 477 479 +2 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before metadata that looked like:
Would error with:
That's because when processing
databases.legislatorsitems, we skip overtablesbut notqueries. We "skip" them because we processing them separately as "table-level" metadata items.Don't merge yet, want to test this more. Shouldn't we also have a block to process
queriesseparately too?📚 Documentation preview 📚: https://datasette--2386.org.readthedocs.build/en/2386/