Make hash and size a lazy property#1837
Merged
simonw merged 4 commits intosimonw:mainfrom Oct 27, 2022
Merged
Conversation
Codecov ReportBase: 92.50% // Head: 92.50% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1837 +/- ##
=======================================
Coverage 92.50% 92.50%
=======================================
Files 35 35
Lines 4400 4400
=======================================
Hits 4070 4070
Misses 330 330 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Owner
|
Yeah this is better, thanks! |
simonw
pushed a commit
that referenced
this pull request
Oct 28, 2022
* use inspect data for hash and file size * make hash and cached_size lazy properties * move hash property near size
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many apologies, @simonw. My previous PR #1835 did not really solve the problem because the name of the database is often not known to database object in the init method.
I took a cue from how you dealt with this issue and made hash a lazy property and did something similar with size.
📚 Documentation preview 📚: https://datasette--1837.org.readthedocs.build/en/1837/