Extract facet portions of table.html out into included templates#1759
Merged
simonw merged 1 commit intosimonw:mainfrom Jun 20, 2022
Merged
Extract facet portions of table.html out into included templates#1759simonw merged 1 commit intosimonw:mainfrom
simonw merged 1 commit intosimonw:mainfrom
Conversation
Owner
|
This is a great idea. |
Owner
|
I don't think this change needs any changes to the documentation: https://docs.datasette.io/en/stable/custom_templates.html#custom-templates |
Codecov Report
@@ Coverage Diff @@
## main #1759 +/- ##
=======================================
Coverage 91.67% 91.67%
=======================================
Files 36 36
Lines 4658 4658
=======================================
Hits 4270 4270
Misses 388 388 Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To allow users customise the facet content as they would prefer such as sorting of facet results. ordering of suggested facets etc.