actors_from_ids plugin hook and datasette.actors_from_ids() method#2181
Merged
actors_from_ids plugin hook and datasette.actors_from_ids() method#2181
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2181 +/- ##
=======================================
Coverage 92.68% 92.69%
=======================================
Files 40 40
Lines 6017 6025 +8
=======================================
+ Hits 5577 5585 +8
Misses 440 440
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here. |
Owner
Author
|
I've implemented this hook once now in: And built and tested a debug tool for it in: I'm now confident in the design of this plugin hook, I'm going to land it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs:
actors_from_ids()#2180This plugin hook is feature complete - including documentation and tests.
I'm not going to land it in Datasette
mainuntil we've used it at least once though, which should happen promptly in development for Datasette Cloud.📚 Documentation preview 📚: https://datasette--2181.org.readthedocs.build/en/2181/