Skip to content

Don't show foreign key links to tables the user cannot access #2178

@simonw

Description

@simonw

Spotted this problem while working on this plugin:

It's possible to make a table public to any users - but then you may end up with situations like this:

CleanShot 2023-09-07 at 10 55 02@2x

That table is public, but the foreign key links go to tables that are NOT public.

We're also leaking the names of the values in those private tables here, which we shouldn't do. So this is a tiny bit of an information leak.

Since this only affects people who have configured a table to be public that has foreign keys to a table that is private I don't think this is worth issuing a vulnerability report about - I very much doubt anyone is running Datasette configured in a way that could result in problems because of this.

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions