Skip to content

Issues 20260322#155

Merged
simoninns merged 5 commits intomainfrom
issues-20260322
Mar 22, 2026
Merged

Issues 20260322#155
simoninns merged 5 commits intomainfrom
issues-20260322

Conversation

@simoninns
Copy link
Copy Markdown
Owner

Summary

This PR bundles the fixes from issues #142, #147, #148, #149, #150, and #151.

  • Fixes the Mask Line stage cache-bounds issue and adds regression coverage for the affected behavior.
  • Fixes the broken README link.
  • Normalizes several GUI shortcuts to avoid OS-level conflicts and improves graph-view deletion behavior by supporting Backspace alongside Delete.
  • Refactors the Field Timing dialog for better responsiveness and usability, including draft rendering during interactive zoom, improved zoom mapping, preserved visible-line state, and cleaner navigation controls.
  • Hardens video-parameter handling across chroma decoding and the video-params stage by introducing shared safety/sanitization logic for unsafe or incomplete metadata, then adds regression tests across the affected decoders and stage paths.
  • Improves the stage-parameter editing flow so video-params can be prefilled and reset from upstream metadata, with stronger cross-field validation and clearer metadata-file warnings in the dialog.

Type of change

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Other

Validation

  • Reviewed the full branch diff against origin/main.
  • Confirmed new/updated unit coverage was added for Mask Line, video_params, and chroma_sink decoder/stage safety paths.
  • Checked the latest recorded local CTest artifacts. The most recent recorded full test run is not clean and still lists 1 failing test:
    • PalColourTest.decodeFrames_compositePath_matchesGoldenVector
  • No fresh build or test run was started as part of preparing this PR summary.

Checklist

  • Scope is focused and minimal
  • Build passes locally
  • Related docs were updated if needed
  • Linked issue (if applicable)

Related issue

Closes #142, #147, #148, #149, #150, #151

@simoninns simoninns merged commit 4b9db25 into main Mar 22, 2026
14 checks passed
@simoninns simoninns deleted the issues-20260322 branch March 22, 2026 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Mask Line crashes FFMPEG stage after tens / hundreds of frames

1 participant