Skip to content

[Bug] Video Parameters Reset to Defaults has no effect #151

@eshaz

Description

@eshaz

Summary

When I click the Reset to Defaults button in the Video Parameters node, it should populate the default values for the video system.
The defaults vary depending on which color system and video line system is in use.

Non-exhaustive list of color / video system combinations that will need a unique set of "defaults":

  • PAL / 625
  • NTSC / 525
  • PAL / 525
  • (perhaps others)

Steps to reproduce

  1. Load a vhs-decode Y/C TBC decode
  2. Add the video parameters transform node, as seen in the screenshot
  3. Right click on the node, click Edit Parameters
  4. Click Reset to Defaults, and nothing is changed from -1

Expected behavior

Clicking the Reset to Defaults button should populate the video parameter options to the correct color / video system defaults.

Actual behavior

It does nothing.

Environment

  • OS: Ubuntu 24.04
  • Build/commit: 4280e36
  • Component: orc-gui

Additional context

Image

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions