Skip to content

Conversation

@pauldreik
Copy link
Collaborator

@pauldreik pauldreik commented Dec 12, 2025

this fixes the newly introduced constexpr related compilation error on aarch64 reported in #874

@lemire
Copy link
Member

lemire commented Dec 12, 2025

It looks like your patch fixes the issue.

@pauldreik pauldreik force-pushed the fix_aarch64_constexpr_build_error branch from 5d27535 to d011f85 Compare December 13, 2025 03:14
@MacroModel
Copy link

My tests passed without issues, and the compilation succeeded.

@pauldreik pauldreik force-pushed the fix_aarch64_constexpr_build_error branch from d011f85 to 629b7cf Compare December 13, 2025 13:29
@pauldreik
Copy link
Collaborator Author

the clang job took longer than 1500 seconds and was cut by the default ctest timeout of 1500 seconds. the tests in release mode on clang took 1347 seconds on my raspberry pi 4. so already without emulation, close to not making the limit.

@pauldreik pauldreik force-pushed the fix_aarch64_constexpr_build_error branch 2 times, most recently from e351f57 to 93dc192 Compare December 13, 2025 15:24
@pauldreik pauldreik marked this pull request as ready for review December 13, 2025 15:26
@pauldreik
Copy link
Collaborator Author

@lemire I think the actual fix is noncontroversial and could be merged, but the changes with SIMDUTF_FAST_TESTS needs review.

@lemire
Copy link
Member

lemire commented Dec 13, 2025

@pauldreik

I am puzzled as to why tests should be running too long now? Didn't they work in the past ?

In any case, PR #876 looks promising.

I can review whenever you want. I reviewed your code change and it is good, verified.

Do you want to split the work in two PRs ?

@pauldreik pauldreik force-pushed the fix_aarch64_constexpr_build_error branch from 93dc192 to afee3d5 Compare December 14, 2025 08:11
@pauldreik
Copy link
Collaborator Author

I am also puzzled why it would fail now. Maybe there was larger pressure on github than usual?
No, I can't remember seeing CI timeouts before.

I will split this in two PR-s since they are two different problems and it is more easy to see afterwards what has changed.

Merging this bug fix first, then let's keep going in the other PR!

@pauldreik pauldreik merged commit b34887b into master Dec 14, 2025
69 of 74 checks passed
@pauldreik pauldreik deleted the fix_aarch64_constexpr_build_error branch December 14, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants