-
Notifications
You must be signed in to change notification settings - Fork 116
Fix aarch64 constexpr build error #875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
815affe to
5d27535
Compare
|
It looks like your patch fixes the issue. |
5d27535 to
d011f85
Compare
|
My tests passed without issues, and the compilation succeeded. |
d011f85 to
629b7cf
Compare
|
the clang job took longer than 1500 seconds and was cut by the default ctest timeout of 1500 seconds. the tests in release mode on clang took 1347 seconds on my raspberry pi 4. so already without emulation, close to not making the limit. |
e351f57 to
93dc192
Compare
|
@lemire I think the actual fix is noncontroversial and could be merged, but the changes with SIMDUTF_FAST_TESTS needs review. |
|
I am puzzled as to why tests should be running too long now? Didn't they work in the past ? In any case, PR #876 looks promising. I can review whenever you want. I reviewed your code change and it is good, verified. Do you want to split the work in two PRs ? |
93dc192 to
afee3d5
Compare
|
I am also puzzled why it would fail now. Maybe there was larger pressure on github than usual? I will split this in two PR-s since they are two different problems and it is more easy to see afterwards what has changed. Merging this bug fix first, then let's keep going in the other PR! |
this fixes the newly introduced constexpr related compilation error on aarch64 reported in #874