introduce cmake option SIMDUTF_FAST_TESTS #876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
273218d to
806d955
Compare
this is to make it possible to run testing for slow targets within reasonable time. it could also be used to cut down testing time in CI. some of the extensive tests (those working with random data) are mostly covered by fuzzing (see the fuzz/ directory in the root).
806d955 to
95760bb
Compare
679408c to
6eca7e6
Compare
6eca7e6 to
0825c95
Compare
Collaborator
Author
|
@lemire this seems to work well now. total time for ci is much lower than before. |
Member
One sideeffect of increased parallelism is increased memory usage... which is why I typically err on the side of not using too much parallelism in CI. But, clearly, it works currently, so my concern is not substantiated as of now. |
Collaborator
Author
agree! I had the same reasoning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our CI takes a long time. Part of it is because the tests take a long time. When working with the emulated aarch64 ci job, it timed out with the default 1500 seconds limit.
This PR introduces a cmake option SIMDUTF_FAST_TESTS which when set to on (default is off) adjusts the parameters of some tests to make them run with fewer iterations/smaller sizes so they finish faster. All the tests still run, just reduced. An example: the tests that use random data use fewer iterations.
Testing a release build locally on amd64, I get
This also modifies ci jobs to run building and testing in parallel.