fixing Issue 824 (work in progress) #825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I am currently busy but I will come back to this issue and complete it before the end of July. |
Contributor
|
Hello @lemire , are the failures in CI expected? https://github.com/simdutf/simdutf/actions/runs/16664634255/job/47168440893#step:4:476 https://github.com/simdutf/simdutf/actions/runs/16664634255/job/47168440893#step:4:524 I encountered these in my Zig build port: https://github.com/sno2/simdutf/actions/runs/16739282767/job/47384236853#step:4:13 |
Member
Author
|
@sno2 Yes. They resulted from a faulty test that I wrote hastily. The test is itself unsafe (but not the code). |
syg
added a commit
to syg/WebKit
that referenced
this pull request
Oct 21, 2025
https://bugs.webkit.org/show_bug.cgi?id=301152 Include a Radar link (OOPS!). Reviewed by NOBODY (OOPS!). The simdutf library had a bug that returned the incorrect read length when the last chunk handling option is "stop-before-partial". This bug has since been fixed upstream in simdutf/simdutf#825. This PR update simdutf to 7.5.0 and removes the hack. Testing is already covered by test262, specifically built-ins/Uint8Array/prototype/setFromBase64.
syg
added a commit
to syg/WebKit
that referenced
this pull request
Oct 21, 2025
https://bugs.webkit.org/show_bug.cgi?id=301158 rdar://163082878 Reviewed by NOBODY (OOPS!). The simdutf library had a bug that returned the incorrect read length when the last chunk handling option is "stop-before-partial". This bug has since been fixed upstream in simdutf/simdutf#825. This PR update simdutf to 7.5.0 and removes the hack. Testing is already covered by test262, specifically built-ins/Uint8Array/prototype/setFromBase64.
syg
added a commit
to syg/WebKit
that referenced
this pull request
Oct 21, 2025
https://bugs.webkit.org/show_bug.cgi?id=301158 rdar://163082878 Reviewed by NOBODY (OOPS!). The simdutf library had a bug that returned the incorrect read length when the last chunk handling option is "stop-before-partial". This bug has since been fixed upstream in simdutf/simdutf#825. This PR updates simdutf to 7.5.0 and removes the hack. Testing is already covered by test262, specifically built-ins/Uint8Array/prototype/setFromBase64.
webkit-commit-queue
pushed a commit
to syg/WebKit
that referenced
this pull request
Oct 21, 2025
https://bugs.webkit.org/show_bug.cgi?id=301158 rdar://163082878 Reviewed by Yusuke Suzuki. The simdutf library had a bug that returned the incorrect read length when the last chunk handling option is "stop-before-partial". This bug has since been fixed upstream in simdutf/simdutf#825. This PR updates simdutf to 7.5.0 and removes the hack. Testing is already covered by test262, specifically built-ins/Uint8Array/prototype/setFromBase64. Canonical link: https://commits.webkit.org/301889@main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #824 once completed.
Thanks for the report by @syg
This PR changes the following things...
AAAA, we would declare having read 4 characters.I have added some tests.