fix: add tests related to issue 2227 by lemire · Pull Request #2229 · simdjson/simdjson

lemire · 2024-08-07T19:13:45Z

The core idea is that you should never hold either an ondemand::array or ondemand::object without a corresponding ondemand::document being alive.

See issue #2227

lemire · 2024-08-07T19:14:22Z

@the-moisrex Please review.

the-moisrex · 2024-08-07T20:03:53Z

GCC 14.2.1 gives this:

/simdjson/tests/ondemand/compilation_failure_tests/iterate_array.cpp: In function ‘int main()’:
/simdjson/tests/ondemand/compilation_failure_tests/iterate_array.cpp:32:11: error: ‘a’ may be used uninitialized [-Werror=maybe-uninitialized]
   32 |     printf("a = %d\n", (int)a);
      |     ~~~~~~^~~~~~~~~~~~~~~~~~~~
/simdjson/tests/ondemand/compilation_failure_tests/iterate_array.cpp:27:13: note: ‘a’ was declared here
   27 |     int64_t a;
      |             ^

the-moisrex · 2024-08-07T20:04:43Z

Oh I see you fixed it!

lemire · 2024-08-07T20:05:39Z

Oh I see you fixed it!

Yeah. Well. It is a bogus warning. GCC is wrong. The value will be initialized but the compiler can't see it for some reason. Very annoying.

the-moisrex · 2024-08-07T20:12:26Z

Honestly my opinion on this is to deprecate document::get() && fully because even supposedly if this code is okay:

    auto error = f(parser).get_double().get(dbl);

The problem is people WILL customize it to be used like this:

    struct Car {
        ondemand::array arr;
    };
    auto error = f(parser).get<Car>().get(car);

This introduces the same problem again.

lemire · 2024-08-07T20:14:04Z

@the-moisrex I agree that is a concern.

lemire · 2024-08-07T20:34:59Z

@the-moisrex Please see 72d6111

the-moisrex · 2024-08-07T20:41:34Z

How about [[deprecated]] attribute? https://en.cppreference.com/w/cpp/language/attributes/deprecated

This library is C++17 right?

lemire · 2024-08-07T21:12:26Z

This library is C++17 right?

No. It is C++11.

the-moisrex · 2024-08-07T21:14:17Z

For some reason I though this project was C++17! I hope I didn't mess something up with that in my mind!

lemire · 2024-08-07T21:45:19Z

For some reason I though this project was C++17! I hope I didn't mess something up with that in my mind!

The build target is C++11 (except for some runners where we go up to C++20). In any case, this new work won't go into our main branch and won't be released until it undergoes sufficient testing.

lemire · 2024-08-08T00:15:03Z

Let us merge this, it seems reasonable.

* fix: add tests related to issue 2227 (#2229) * fix: add tests related to issue 2227 * avoiding name clash * pedantic fix * deprecate rvalue get on document * selectively deprecating * Fix ndjson spec link (#2234) * fix ndjson spec link The link in the readme of parse_many links to a casino spam site * fix link * [no-ci] Update README.md * Make simdjson compile again * Enable SIMDJSON_SINGLEHEADER=OFF in VS Code With singleheader on, clangd can't find the right include files. * Add missing include directives to static build targets of simdjson. (#2240) * adding a warning * adding warning regarding SIMDJSON_BUILD_STATIC_LIB * release candidate * pedantic viable size * Making tag_invoke a feeder instead of a producer * adding missing undef silencer (#2253) * Ignore pragma once when amalgamating source files (#2248) With gcc it causes an error in `simdjson.cpp`: ``` simdjson.cpp:548:9: warning: #pragma once in main file 548 | #pragma once | ^~~~ ``` It had previously been commented out in: 6ef555e However, this was lost in an upgrade: 2a4ff73 * Update CI (#2254) * adding missing undef silencer * Updating CI * more fixes * fix * big endian fix * Moving to the new tag_invoke signature * Fix nlohmann ambiguity on C++23-enabled clang * Revert "Merge branch 'master' of https://github.com/simdjson/simdjson into builder_development_branch_extra" This reverts commit 3eeecba, reversing changes made to 6858b20. --------- Co-authored-by: Daniel Lemire <daniel@lemire.me> Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com> Co-authored-by: John Keiser <john@johnkeiser.com> Co-authored-by: Tan Li Boon <undisputed-seraphim@users.noreply.github.com> Co-authored-by: tobil4sk <tobil4sk@outlook.com>

@lemire

* tag_invoke based custom types (#2219) * tag_invoke based custom types Now you can use tag_invoke to add a custom type or a group of custom types. * Fixing macro usage + Fixing noexcept * Fixing the usage of #include We don't need <concepts> at all seems like it * Fixing tag_invoke impl for MSVC * Making `tag_invoke` to support `ondemand::document` as well + docs (#2228) * Making `tag_invoke` to support `ondemand::document` as well + docs * Fix typos and doc update by @lemire Co-authored-by: Daniel Lemire <daniel@lemire.me> * Better docs by @lemire Co-authored-by: Daniel Lemire <daniel@lemire.me> * Preserving the old, disallowing in the new I'm disabling `document::get() &&` if the user has provided a `tag_invoke`d version; otherwise, we retain the compatibility. --------- Co-authored-by: Daniel Lemire <daniel@lemire.me> * fix: correct small issues with deserialize (#2232) * Extending the deserialization code with more defaults + docs (#2233) * Make custom types easier with some predefined cases + docs * missing include * adding Ubuntu 24 CXX 20 * using concepts all the way * minor tweak * tiny tweak * tweaks * more tweaking * saving --------- Co-authored-by: Daniel Lemire <dlemire@lemire.me> * Making `tag_invoke` a "put" as opposed to a "get" (#2256) * fix: add tests related to issue 2227 (#2229) * fix: add tests related to issue 2227 * avoiding name clash * pedantic fix * deprecate rvalue get on document * selectively deprecating * Fix ndjson spec link (#2234) * fix ndjson spec link The link in the readme of parse_many links to a casino spam site * fix link * [no-ci] Update README.md * Make simdjson compile again * Enable SIMDJSON_SINGLEHEADER=OFF in VS Code With singleheader on, clangd can't find the right include files. * Add missing include directives to static build targets of simdjson. (#2240) * adding a warning * adding warning regarding SIMDJSON_BUILD_STATIC_LIB * release candidate * pedantic viable size * Making tag_invoke a feeder instead of a producer * adding missing undef silencer (#2253) * Ignore pragma once when amalgamating source files (#2248) With gcc it causes an error in `simdjson.cpp`: ``` simdjson.cpp:548:9: warning: #pragma once in main file 548 | #pragma once | ^~~~ ``` It had previously been commented out in: 6ef555e However, this was lost in an upgrade: 2a4ff73 * Update CI (#2254) * adding missing undef silencer * Updating CI * more fixes * fix * big endian fix * Moving to the new tag_invoke signature * Fix nlohmann ambiguity on C++23-enabled clang * Revert "Merge branch 'master' of https://github.com/simdjson/simdjson into builder_development_branch_extra" This reverts commit 3eeecba, reversing changes made to 6858b20. --------- Co-authored-by: Daniel Lemire <daniel@lemire.me> Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com> Co-authored-by: John Keiser <john@johnkeiser.com> Co-authored-by: Tan Li Boon <undisputed-seraphim@users.noreply.github.com> Co-authored-by: tobil4sk <tobil4sk@outlook.com> * update CI on the builder_development_branch (no code change) (#2262) * typo * General madness simpler, no simpler!!! (#2267) * Minimal tag_invokes for STL types * simpler madness * adding a comment * missing file * minor tweaks to style * fixing incorrect max/min usage * updating single * simplify * validating the idea * putting back the concept * moving the include * guarding * Cheap General Madness (#2268) * Some General Concepts and their deserializations * Resolving ambiguity * Add missing #include * C++20 custom deserializer: better documentation (#2269) * mostly a documentation update. * missing cpp * [no-ci] fix comment * various minor fixes --------- Co-authored-by: Daniel Lemire <dlemire@lemire.me> --------- Co-authored-by: M. Bahoosh <12122474+the-moisrex@users.noreply.github.com> Co-authored-by: Daniel Lemire <dlemire@lemire.me> Co-authored-by: M. Bahoosh <moisrex@gmail.com> * minor update * More documentation regarding builder (#2270) * minor update * more improvment to our documentation (builder branch) * putting back missing functions * merge candidate --------- Co-authored-by: M. Bahoosh <moisrex@gmail.com> Co-authored-by: Daniel Lemire <dlemire@lemire.me> Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com> Co-authored-by: John Keiser <john@johnkeiser.com> Co-authored-by: Tan Li Boon <undisputed-seraphim@users.noreply.github.com> Co-authored-by: tobil4sk <tobil4sk@outlook.com> Co-authored-by: M. Bahoosh <12122474+the-moisrex@users.noreply.github.com>

fix: add tests related to issue 2227

2ecf6a2

lemire mentioned this pull request Aug 7, 2024

Making tag_invoke to support ondemand::document as well + docs #2228

Merged

lemire added 2 commits August 7, 2024 15:26

avoiding name clash

5dfd876

pedantic fix

f6fa674

deprecate rvalue get on document

72d6111

selectively deprecating

f77e3f7

lemire merged commit d506af0 into master Aug 8, 2024

lemire deleted the adding_tests_for_rvalues branch August 8, 2024 00:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: add tests related to issue 2227#2229

fix: add tests related to issue 2227#2229
lemire merged 5 commits intomasterfrom
adding_tests_for_rvalues

lemire commented Aug 7, 2024

Uh oh!

lemire commented Aug 7, 2024

Uh oh!

the-moisrex commented Aug 7, 2024

Uh oh!

the-moisrex commented Aug 7, 2024

Uh oh!

lemire commented Aug 7, 2024 •

edited

Loading

Uh oh!

the-moisrex commented Aug 7, 2024

Uh oh!

lemire commented Aug 7, 2024

Uh oh!

lemire commented Aug 7, 2024

Uh oh!

the-moisrex commented Aug 7, 2024 •

edited

Loading

Uh oh!

lemire commented Aug 7, 2024

Uh oh!

the-moisrex commented Aug 7, 2024

Uh oh!

lemire commented Aug 7, 2024

Uh oh!

lemire commented Aug 8, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

lemire commented Aug 7, 2024

Uh oh!

lemire commented Aug 7, 2024

Uh oh!

the-moisrex commented Aug 7, 2024

Uh oh!

the-moisrex commented Aug 7, 2024

Uh oh!

lemire commented Aug 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

the-moisrex commented Aug 7, 2024

Uh oh!

lemire commented Aug 7, 2024

Uh oh!

lemire commented Aug 7, 2024

Uh oh!

the-moisrex commented Aug 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lemire commented Aug 7, 2024

Uh oh!

the-moisrex commented Aug 7, 2024

Uh oh!

lemire commented Aug 7, 2024

Uh oh!

lemire commented Aug 8, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

lemire commented Aug 7, 2024 •

edited

Loading

the-moisrex commented Aug 7, 2024 •

edited

Loading