Skip to content

make TSA validity end optional#1368

Merged
jku merged 8 commits into
sigstore:mainfrom
ramonpetgrave64:tsa-validity-end
May 8, 2025
Merged

make TSA validity end optional#1368
jku merged 8 commits into
sigstore:mainfrom
ramonpetgrave64:tsa-validity-end

Conversation

@ramonpetgrave64

@ramonpetgrave64 ramonpetgrave64 commented May 6, 2025

Copy link
Copy Markdown
Contributor

Client support for Rekor V2: sigstore-python #289

Summary

Resolves #1367

Release Note

Timestamp authority end dates in trust_config made optional.

Documentation

Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
This reverts commit 79a6d31.

Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
@ramonpetgrave64 ramonpetgrave64 changed the title Tsa validity end make TSA validity end optional May 7, 2025
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>

@jku jku left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

I edited the PR message to fix the issue link

@jku

jku commented May 7, 2025

Copy link
Copy Markdown
Member

/gcbrun

@jku jku left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, could you add a line in CHANGELOG about this?

(add a "fixed" section under unreleased if one does not exist already)

ramonpetgrave64 and others added 3 commits May 7, 2025 15:08
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <32398091+ramonpetgrave64@users.noreply.github.com>
Signed-off-by: Ramon Petgrave <32398091+ramonpetgrave64@users.noreply.github.com>
@jku

jku commented May 8, 2025

Copy link
Copy Markdown
Member

/gcbrun

@jku jku merged commit 2199d9b into sigstore:main May 8, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support timestamp validity periods without end dates

2 participants