cliplugin: semver, add tests for hash func encoding#1948
Merged
Hayden-IO merged 59 commits intosigstore:mainfrom Feb 6, 2025
Merged
cliplugin: semver, add tests for hash func encoding#1948Hayden-IO merged 59 commits intosigstore:mainfrom
Hayden-IO merged 59 commits intosigstore:mainfrom
Conversation
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
…monpetgrave64-kms-plugin-cli-cryptosigner Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
…monpetgrave64-kms-plugin-cli-cryptosigner Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
This reverts commit 80f74bc. Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
This reverts commit fb9bb93. Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
This reverts commit 768bc6b. Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
22 tasks
0862508 to
ca8d65c
Compare
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
ca8d65c to
1384652
Compare
…working Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
…to ramonpetgrave64-kms-plugin-cli-context Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
…ave64-kms-plugin-cli-hashencoding Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
…ave64-kms-plugin-cli-hashencoding
1 task
Hayden-IO
reviewed
Feb 5, 2025
| // Plugin authors may choose to be backwards compatible with older versions. | ||
| // TODO: change this to be semver compatible, like v1, or v1.0.0. | ||
| ProtocolVersion = "1" | ||
| ProtocolVersion = "v1.0.0" |
Contributor
There was a problem hiding this comment.
I think this amount of semver specificity is overkill and a single major version should be sufficient. Clients don't need to be aware of non-breaking changes to the protocol.
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Hayden-IO
reviewed
Feb 6, 2025
Contributor
Hayden-IO
left a comment
There was a problem hiding this comment.
LGTM, just needs rebase
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Hayden-IO
approved these changes
Feb 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pending #1947, branch diff: ramonpetgrave64/sigstore@ramonpetgrave64-kms-plugin-cli-context...ramonpetgrave64:sigstore:ramonpetgrave64-kms-plugin-cli-hashencoding
Adds tests against know hash func and their JSON encoding.
The current set of hash funcs and their encoding has not changed in ~8 years, but they might change in the future, since they are ordered by iota.
This PR
Release Note
The plugin protocol version now uses semver at "v1.0.0".
Documentation
No new documentation changes