cliplugin: use caller contexts#1947
Merged
Hayden-IO merged 56 commits intosigstore:mainfrom Feb 6, 2025
Merged
Conversation
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
…monpetgrave64-kms-plugin-cli-cryptosigner Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
…monpetgrave64-kms-plugin-cli-cryptosigner Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
This reverts commit 80f74bc. Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
This reverts commit fb9bb93. Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
This reverts commit 768bc6b. Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
019ff94 to
0599c81
Compare
This was referenced Jan 28, 2025
…working Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
…to ramonpetgrave64-kms-plugin-cli-context Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
bobcallaway
reviewed
Feb 5, 2025
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Hayden-IO
reviewed
Feb 5, 2025
bobcallaway
reviewed
Feb 5, 2025
Comment on lines
+210
to
+212
| if err := ctx.Err(); err != nil { | ||
| return nil, nil, err | ||
| } |
Member
There was a problem hiding this comment.
it feels off to check this at the time of object creation instead of object usage.
Contributor
Author
There was a problem hiding this comment.
I'm thinking of this context as having a deadline that's specific for object initialization. If the caller wants to reuse the same context in method calls, then that's okay.
Contributor
There was a problem hiding this comment.
For what reason would this have an error at this point?
Contributor
Author
There was a problem hiding this comment.
If the context already expired, then no reason to continue trying to initialize the CrytpoSigner.
Also this article talks about using contexts in initializer functions, and that reusing it for methods leads to confusion.
Contributor
Author
There was a problem hiding this comment.
Also, does it make sense to call the errFunc here?
Contributor
|
Just a meta comment: The commit history seems to be pulling in tons of old commits. It's not a big deal since we'll squash the commit before merge, but it's hard to follow the changes in this PR, so I'd suggest rebasing off main as we merge PRs. |
Hayden-IO
approved these changes
Feb 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pending #1946. See branch diff: ramonpetgrave64/sigstore@ramonpetgrave64-kms-plugin-cli-cryptosigner-working...ramonpetgrave64:sigstore:ramonpetgrave64-kms-plugin-cli-context
Makes PluginClient methods use the contexts of the original caller when calling invokePlugin. The benefit is that the Cmd can be cancelled using the caller's cancel func.
Release Note
PluginClient methods can be cancelled with the caller's context cancel func.
Documentation