Merged
Conversation
Member
cpanato
commented
Oct 15, 2024
- bump to go 1.22.8
Signed-off-by: cpanato <ctadeu@gmail.com>
bobcallaway
approved these changes
Oct 15, 2024
hectorj2f
approved these changes
Oct 15, 2024
|
Hi folks. Out of curiosity, is there any specific reason for these Golang version bumps? A bump here requires to bump the version also on consumers of this library, like Inspektor Gadget on inspektor-gadget/inspektor-gadget#3589. |
dnwe
added a commit
to dnwe/sigstore
that referenced
this pull request
Nov 5, 2024
The go directive sets the minimum version of Go required to use this module. There's no need to set this to the latest semver patch version of a given Go release unless the semantics of that version of Go are required to build/test/use the module. Notably since PR sigstore#1865 any consumers of sigstore as a library would need to bump their own go directive to 1.22.8 in order to pickup the sigstore 1.8.10 release. https://go.dev/ref/mod#go-mod-file-go
dnwe
added a commit
to dnwe/sigstore
that referenced
this pull request
Nov 5, 2024
The go directive sets the minimum version of Go required to use this module. There's no need to set this to the latest semver patch version of a given Go release unless the semantics of that version of Go are required to build/test/use the module. Notably since PR sigstore#1865 any consumers of sigstore as a library would need to bump their own go directive to 1.22.8 in order to pickup the sigstore 1.8.10 release. Ref: https://go.dev/ref/mod#go-mod-file-go Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
This was referenced Nov 5, 2024
Contributor
|
Raised an issue and a PR for the above ^ |
ramonpetgrave64
pushed a commit
to ramonpetgrave64/sigstore
that referenced
this pull request
Dec 13, 2024
Signed-off-by: cpanato <ctadeu@gmail.com> Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
ramonpetgrave64
pushed a commit
to ramonpetgrave64/sigstore
that referenced
this pull request
Jan 22, 2025
Signed-off-by: cpanato <ctadeu@gmail.com>
ramonpetgrave64
pushed a commit
to ramonpetgrave64/sigstore
that referenced
this pull request
Jan 22, 2025
Signed-off-by: cpanato <ctadeu@gmail.com> Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.