Create utility for generating Tink keysets#1627
Merged
Merged
Conversation
tinkey requires a Java runtime environment and doesn't support outputting PEM-encoded public keys. Threw together this utility to generate keysets and output the keyset's primary key. This will be used when spinning up new log shards to create key material. Signed-off-by: Hayden B <8418760+haydentherapper@users.noreply.github.com>
Contributor
Author
|
Putting this in Scaffolding so it can be used across deployments that need Tink keysets. |
Hayden-IO
pushed a commit
to sigstore/fulcio
that referenced
this pull request
Jul 10, 2025
sigstore/scaffolding#1627 replaces it. Signed-off-by: Hayden <haydentherapper@users.noreply.github.com>
jku
approved these changes
Jul 10, 2025
jku
left a comment
Member
There was a problem hiding this comment.
This seems like a good idea.
A mention in the README (or in some docs) would be nice but none of the other tools seem to be documented either so 🤷
Signed-off-by: Hayden B <8418760+haydentherapper@users.noreply.github.com>
Contributor
Author
|
Thanks for the README suggestion, I added a doc for the command. We need to update the top-level readme in this repo as well. |
cmurphy
approved these changes
Jul 10, 2025
bobcallaway
previously approved these changes
Jul 17, 2025
bobcallaway
left a comment
Member
There was a problem hiding this comment.
would be nice to get CI to test building this code on PRs this at some point
Contributor
Author
|
Added CI. |
Signed-off-by: Hayden B <8418760+haydentherapper@users.noreply.github.com>
2c018bd to
3a78ea9
Compare
bobcallaway
reviewed
Jul 17, 2025
bobcallaway
approved these changes
Jul 30, 2025
Hayden-IO
pushed a commit
to sigstore/fulcio
that referenced
this pull request
Jul 30, 2025
sigstore/scaffolding#1627 replaces it. Signed-off-by: Hayden <haydentherapper@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tinkey requires a Java runtime environment and doesn't support outputting PEM-encoded public keys. Threw together this utility to generate keysets and output the keyset's primary key. This will be used when spinning up new log shards to create key material.
Summary
Release Note
Documentation