Merged
Conversation
Signed-off-by: Bob Callaway <bcallaway@google.com>
cpanato
approved these changes
Aug 29, 2023
Codecov Report
@@ Coverage Diff @@
## main #1651 +/- ##
===========================================
- Coverage 66.93% 48.95% -17.99%
===========================================
Files 88 88
Lines 8804 8804
===========================================
- Hits 5893 4310 -1583
- Misses 2213 3647 +1434
- Partials 698 847 +149
Flags with carried forward coverage won't be shown. Click here to find out more. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1580 included
context.WithCancelwhich is only available in go 1.21. our CI actions were already bumped for this, but when building rekor locally we should match.