feat: Support publishing new log entries to Pub/Sub topics#1580
Merged
bobcallaway merged 1 commit intosigstore:mainfrom Aug 28, 2023
Merged
feat: Support publishing new log entries to Pub/Sub topics#1580bobcallaway merged 1 commit intosigstore:mainfrom
bobcallaway merged 1 commit intosigstore:mainfrom
Conversation
5f1c40a to
c0f2d85
Compare
Contributor
Author
|
@bobcallaway Please note the build will fail as-is due to dependency on sigstore/protobuf-specs#86 which hasn't been merged yet. All tests pass running locally when using the not-yet-merged dependency: https://gist.github.com/jalseth/ebf866def89661d31fd87c93eed80ed2 |
Hayden-IO
reviewed
Jul 26, 2023
Contributor
Hayden-IO
left a comment
There was a problem hiding this comment.
Fantastic work on this!
Hayden-IO
reviewed
Jul 28, 2023
15c34c1 to
7624f62
Compare
f83b1b3 to
7a161df
Compare
Codecov Report
@@ Coverage Diff @@
## main #1580 +/- ##
==========================================
- Coverage 67.04% 66.94% -0.10%
==========================================
Files 83 88 +5
Lines 8490 8804 +314
==========================================
+ Hits 5692 5894 +202
- Misses 2120 2213 +93
- Partials 678 697 +19
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bobcallaway
reviewed
Aug 22, 2023
Member
bobcallaway
left a comment
There was a problem hiding this comment.
lgtm overall, a couple questions
Hayden-IO
reviewed
Aug 22, 2023
Contributor
Hayden-IO
left a comment
There was a problem hiding this comment.
LGTM with just a few nits
771eccc to
ffa4537
Compare
Adds initial support publishing new log entries to Pub/Sub topics. Interested parties can subscribe to the topic in order to receive notifications when new entries are added. Signed-off-by: James Alseth <james@jalseth.me>
bobcallaway
approved these changes
Aug 27, 2023
Hayden-IO
approved these changes
Aug 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds initial support publishing new log entries to Pub/Sub topics. Interested parties can subscribe to the topic in order to receive notifications when new entries are added.
This relates to #191. Requires sigstore/protobuf-specs#86 to be merged.
Release Note
rekor_server.new_entry_publisherflag to configure the Pub/Sub topic to send notifications to when a new log entry is added. This flag is optional.rekor_server.publish_events_protobufflag to configure whether events are published using the CloudEvents protobuf format.rekor_server.publish_events_jsonflag to configure whether events are published using the CloudEvents JSON format.Documentation
This is a TODO still. I would like feedback on the PR before writing the docs.