Skip to content

Bump sigstore library dependencies#4532

Merged
Hayden-IO merged 1 commit into
sigstore:mainfrom
Hayden-IO:bump-ss
Dec 2, 2025
Merged

Bump sigstore library dependencies#4532
Hayden-IO merged 1 commit into
sigstore:mainfrom
Hayden-IO:bump-ss

Conversation

@Hayden-IO

Copy link
Copy Markdown
Contributor

Summary

Release Note

Documentation

@Hayden-IO Hayden-IO requested review from a team as code owners November 19, 2025 16:33
cpanato
cpanato previously approved these changes Nov 19, 2025
@Hayden-IO

Copy link
Copy Markdown
Contributor Author

Will need to wait for sigstore/sigstore-go#543 to merge to remove TSA v1 dependency

@frewilhelm

Copy link
Copy Markdown
Contributor

Will need to wait for sigstore/sigstore-go#543 to merge to remove TSA v1 dependency

sigstore/sigstore-go#543 is merged. Do you know when #4532 can be merged?

@Hayden-IO

Copy link
Copy Markdown
Contributor Author

Will need to wait for sigstore/sigstore-go#543 to merge to remove TSA v1 dependency

sigstore/sigstore-go#543 is merged. Do you know when #4532 can be merged?

Updating now.

@codecov

codecov Bot commented Dec 1, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 36.27%. Comparing base (2ef6022) to head (cab7ffa).
⚠️ Report is 599 commits behind head on main.

Files with missing lines Patch % Lines
pkg/cosign/keys.go 40.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4532      +/-   ##
==========================================
- Coverage   40.10%   36.27%   -3.83%     
==========================================
  Files         155      220      +65     
  Lines       10044    12321    +2277     
==========================================
+ Hits         4028     4470     +442     
- Misses       5530     7156    +1626     
- Partials      486      695     +209     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Hayden-IO Hayden-IO force-pushed the bump-ss branch 2 times, most recently from fd80bcf to 7ad141c Compare December 1, 2025 18:53
@Hayden-IO Hayden-IO requested a review from cpanato December 1, 2025 19:06
Signed-off-by: Hayden <8418760+haydentherapper@users.noreply.github.com>
@Hayden-IO Hayden-IO merged commit 38bf9e6 into sigstore:main Dec 2, 2025
29 checks passed
@frewilhelm

Copy link
Copy Markdown
Contributor

do you plan to backport this to a v2.6.x release?

@rosstimothy

Copy link
Copy Markdown

+1 to backporting this to v2. v3 requires Go 1.25 which may not be something that all consumers of this library are capable of at the moment.

@Hayden-IO

Copy link
Copy Markdown
Contributor Author

We can work on backporting the patches to v2. Backporting is going to end up bumping v2 to 1.25 though, we've pulled in some dependencies that are setting their min version as 1.25.

@rosstimothy

Copy link
Copy Markdown

We can work on backporting the patches to v2. Backporting is going to end up bumping v2 to 1.25 though, we've pulled in some dependencies that are setting their min version as 1.25.

Is there a specific need for 1.25 to resolve the security issue? If not can it be avoided?

@Hayden-IO

Copy link
Copy Markdown
Contributor Author

No, it's not needed for resolving the issue, but a dependency somewhere deep in the dep tree bumped its version directive and so the latest releases of fulcio and timestamp-authority were bumped as well. We've tried to keep the go version as low as possible, but then we end up having to ignore dependabot updates. No great solution in either case.

@rosstimothy

Copy link
Copy Markdown

No, it's not needed for resolving the issue, but a dependency somewhere deep in the dep tree bumped its version directive and so the latest releases of fulcio and timestamp-authority were bumped as well. We've tried to keep the go version as low as possible, but then we end up having to ignore dependabot updates. No great solution in either case.

Is it possible to fix the issue in timestamp-authority/v1 without bumping to Go 1.25?

@Hayden-IO

Copy link
Copy Markdown
Contributor Author

Fulcio is also at 1.25, which would need to be bumped as well to resolve GHSA-f83f-xpx7-ffpw.

JasonPowr pushed a commit to securesign/cosign that referenced this pull request Jan 5, 2026
Signed-off-by: Hayden <8418760+haydentherapper@users.noreply.github.com>
JasonPowr pushed a commit to securesign/cosign that referenced this pull request Jan 5, 2026
Signed-off-by: Hayden <8418760+haydentherapper@users.noreply.github.com>
fghanmi pushed a commit to securesign/cosign that referenced this pull request Jan 22, 2026
Signed-off-by: Hayden <8418760+haydentherapper@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants