Bump sigstore library dependencies#4532
Conversation
|
Will need to wait for sigstore/sigstore-go#543 to merge to remove TSA v1 dependency |
sigstore/sigstore-go#543 is merged. Do you know when #4532 can be merged? |
Updating now. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4532 +/- ##
==========================================
- Coverage 40.10% 36.27% -3.83%
==========================================
Files 155 220 +65
Lines 10044 12321 +2277
==========================================
+ Hits 4028 4470 +442
- Misses 5530 7156 +1626
- Partials 486 695 +209 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fd80bcf to
7ad141c
Compare
Signed-off-by: Hayden <8418760+haydentherapper@users.noreply.github.com>
|
do you plan to backport this to a |
|
+1 to backporting this to v2. v3 requires Go 1.25 which may not be something that all consumers of this library are capable of at the moment. |
|
We can work on backporting the patches to v2. Backporting is going to end up bumping v2 to 1.25 though, we've pulled in some dependencies that are setting their min version as 1.25. |
Is there a specific need for 1.25 to resolve the security issue? If not can it be avoided? |
|
No, it's not needed for resolving the issue, but a dependency somewhere deep in the dep tree bumped its version directive and so the latest releases of fulcio and timestamp-authority were bumped as well. We've tried to keep the go version as low as possible, but then we end up having to ignore dependabot updates. No great solution in either case. |
Is it possible to fix the issue in timestamp-authority/v1 without bumping to Go 1.25? |
|
Fulcio is also at 1.25, which would need to be bumped as well to resolve GHSA-f83f-xpx7-ffpw. |
Signed-off-by: Hayden <8418760+haydentherapper@users.noreply.github.com>
Signed-off-by: Hayden <8418760+haydentherapper@users.noreply.github.com>
Signed-off-by: Hayden <8418760+haydentherapper@users.noreply.github.com>
Summary
Release Note
Documentation