Skip to content

Rename --subscribe-all-data-column-subnets to --supernode and make it visible in help#8083

Merged
mergify[bot] merged 3 commits into
sigp:unstablefrom
jimmygchen:supernode-flag
Sep 19, 2025
Merged

Rename --subscribe-all-data-column-subnets to --supernode and make it visible in help#8083
mergify[bot] merged 3 commits into
sigp:unstablefrom
jimmygchen:supernode-flag

Conversation

@jimmygchen

Copy link
Copy Markdown
Member

Issue Addressed

Rename --subscribe-all-data-column-subnets to --supernode as it's now been officially accepted in the spec. Also make it visible in help in preparation for the fusaka release.

https://github.com/ethereum/consensus-specs/blob/dev/specs/fulu/p2p-interface.md#supernodes

… now been officially accepted in the spec. Also make it visible in help in preparation for the fusaka release.
@jimmygchen jimmygchen added ready-for-review The code is ready for review docs Documentation low-hanging-fruit Easy to resolve, get it before someone else does! v8.0.0-rc.0 Q3 2025 release for Fusaka on Holesky labels Sep 18, 2025
@mergify

mergify Bot commented Sep 18, 2025

Copy link
Copy Markdown

Some required checks have failed. Could you please take a look @jimmygchen? 🙏

@mergify mergify Bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. ready-for-review The code is ready for review and removed ready-for-review The code is ready for review waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Sep 18, 2025

@pawanjay176 pawanjay176 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would be good to get a ✅ from @barnabasbusa as well to make sure we aren't breaking any setups unexpectedly.

Comment thread lighthouse/tests/beacon_node.rs
@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Sep 19, 2025
mergify Bot added a commit that referenced this pull request Sep 19, 2025
@mergify

mergify Bot commented Sep 19, 2025

Copy link
Copy Markdown

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You can check the last failing draft PR here: #8086.

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

mergify Bot added a commit that referenced this pull request Sep 19, 2025
mergify Bot added a commit that referenced this pull request Sep 19, 2025
@mergify

mergify Bot commented Sep 19, 2025

Copy link
Copy Markdown

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You can check the last failing draft PR here: #8087.

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@jimmygchen

Copy link
Copy Markdown
Member Author

@mergify requeue

@mergify

mergify Bot commented Sep 19, 2025

Copy link
Copy Markdown

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

mergify Bot added a commit that referenced this pull request Sep 19, 2025
@mergify

mergify Bot commented Sep 19, 2025

Copy link
Copy Markdown

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You can check the last failing draft PR here: #8091.

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

mergify Bot added a commit that referenced this pull request Sep 19, 2025
@mergify mergify Bot merged commit 4efe47b into sigp:unstable Sep 19, 2025
38 checks passed
barnabasbusa added a commit to ethpandaops/ethereum-package that referenced this pull request Sep 19, 2025
depends on sigp/lighthouse#8083

Signed-off-by: Barnabas Busa <barnabas.busa@ethereum.org>
barnabasbusa added a commit to ethpandaops/ansible-collection-general that referenced this pull request Sep 19, 2025
depends on sigp/lighthouse#8083

Signed-off-by: Barnabas Busa <busa.barnabas@gmail.com>
darigaaz86 pushed a commit to darigaaz86/kurtosis-eth that referenced this pull request Nov 12, 2025
depends on sigp/lighthouse#8083

Signed-off-by: Barnabas Busa <barnabas.busa@ethereum.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-merge This PR is ready to merge. v8.0.0-rc.0 Q3 2025 release for Fusaka on Holesky

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants