Add --telemetry-service-name CLI flag for OpenTelemetry service name override#7903
Merged
Merged
Conversation
…e override Allows users to customize the OpenTelemetry service name instead of using the hardcoded defaults. Defaults to 'lighthouse-bn' for beacon node, 'lighthouse-vc' for validator client, or 'lighthouse' for other subcommands.
| --telemetry-collector-url <URL> | ||
| URL of the OpenTelemetry collector to export tracing spans (e.g., | ||
| http://localhost:4317). If not set, tracing export is disabled. | ||
| --telemetry-service-name <NAME> |
Member
There was a problem hiding this comment.
This is an orthogonal issue, but probably we don't want these flags displayed prominently on short-lived subcommands like lighthouse vm. I think Mac is going to look into hiding a lot of the irrelevant flags by default:
Member
Author
There was a problem hiding this comment.
Yeah i agree and I thought about that too, the downside is we'd have to duplicate the flags in BN and VC. Would be good to hide them!
On a separate note, we also have a few minor flag usage issues we need to fix, e.g. bootnode panic if run in debug mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Allows users to customize the OpenTelemetry service name instead of using the hardcoded default
lighthouse. Defaults to 'lighthouse-bn' for beacon node, 'lighthouse-vc' for validator client, or 'lighthouse' for other subcommands.This is useful when analysing traces from multiple nodes, see Grafana screenshot below with service name overrides in Kurtosis (
ethereum-packagePR: ethpandaops/ethereum-package#1160):