Serialize bpo schedule in asending order #7753
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some required checks have failed. Could you please take a look @pawanjay176? 🙏 |
jimmygchen
reviewed
Jul 18, 2025
| // Check that serialization is in ascending order | ||
| let yaml = serde_yaml::to_string(&spec.blob_schedule).expect("should serialize"); | ||
|
|
||
| // Deserialize back to Vec<BlobParameters> to check order |
Member
There was a problem hiding this comment.
It's a little weird that a serde round trip result in different ordering. Maybe we should reverse again in deserialize?
It currently don't cause any issue, but if it gets serialized -> deseralized -> serailzied again we'll end up having descending order - might be confusing if this functionality gets used by downstream projects
Member
There was a problem hiding this comment.
Ah nevermind, this is done in the constructor
lighthouse/consensus/types/src/chain_spec.rs
Lines 1486 to 1490 in 03d297d
6 tasks
danielrachi1
pushed a commit
to danielrachi1/lighthouse
that referenced
this pull request
Jul 18, 2025
N/A Serializes the blob_schedule in ascending order to match other clients. This is needed to keep the output of `eth/v1/config/spec` http endpoint consistent across clients. cc @barnabasbusa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
N/A
Proposed Changes
Serializes the blob_schedule in ascending order to match other clients. This is needed to keep the output of
eth/v1/config/spechttp endpoint consistent across clients.cc @barnabasbusa