Prevent reconstruction starting prematurely #6669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
added a commit
that referenced
this pull request
Dec 9, 2024
Squashed commit of the following: commit fa6fadd Author: Michael Sproul <michael@sigmaprime.io> Date: Mon Dec 9 11:30:49 2024 +1100 Prevent reconstruction starting prematurely
Merged
jimmygchen
reviewed
Dec 10, 2024
Member
Author
|
@mergify queue |
✅ The pull request has been merged automaticallyDetailsThe pull request has been merged automatically at fc0e0ae |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Fix a long-standing issue most recently reported by @xrchz whereby Lighthouse attempts to start state reconstruction too early.
Proposed Changes
When starting up, only attempt to start state reconstruction if block backfill is already complete. A similar guard condition already exists at the point in block backfill where we start reconstruction:
lighthouse/beacon_node/beacon_chain/src/historical_blocks.rs
Lines 279 to 284 in c042dc1
Additional Info
Alternatively we could refactor the reconstruction code itself to just log a debug message and return
Ok(())in the case where reconstruction is not yet ready to start. However due to the limited number of places from which reconstruction can be triggered, I think the current approach is preferable, as it avoids sending and processing an unnecessary event.