Skip to content

Remove req_id from CustodyId #6589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mergify merged 1 commit into from
Dec 16, 2024
Merged

Remove req_id from CustodyId #6589

mergify merged 1 commit into from
Dec 16, 2024

Conversation

@ackintosh
Copy link
Member

@ackintosh ackintosh commented Nov 17, 2024

Issue Addressed

N/A

Proposed Changes

Removed req_id from CustodyId because it's not used.

@ackintosh ackintosh added the ready-for-review The code is ready for review label Nov 18, 2024
jxs
jxs approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. das Data Availability Sampling and removed ready-for-review The code is ready for review labels Dec 16, 2024
@jimmygchen
Copy link
Member

jimmygchen commented Dec 16, 2024

@mergify queue

@mergify
Copy link

mergify bot commented Dec 16, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

Details

Pull request #6589 has been dequeued by a dequeue command.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

mergify bot added a commit that referenced this pull request Dec 16, 2024
@mergify
Merge of #6589
c3eb70a
This was referenced Dec 16, 2024
Closed
Merged
@jimmygchen
Copy link
Member

jimmygchen commented Dec 16, 2024

@mergify dequeue

@mergify mergify bot mentioned this pull request Dec 16, 2024
Merged
@mergify
Copy link

mergify bot commented Dec 16, 2024

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #6589 has been dequeued by a dequeue command.

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@mergify
Copy link

mergify bot commented Dec 16, 2024

dequeue

✅ The pull request has been removed from the queue default

@jimmygchen
Copy link
Member

jimmygchen commented Dec 16, 2024

@mergify requeue

@mergify
Copy link

mergify bot commented Dec 16, 2024

requeue

✅ This pull request will be re-embarked automatically

Details

The followup queue command will be automatically executed to re-embark the pull request

@mergify
Copy link

mergify bot commented Dec 16, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

Details

The pull request has been merged automatically at 75d9079

mergify bot added a commit that referenced this pull request Dec 16, 2024
@mergify
Merge of #6589
eb06a14
This was referenced Dec 16, 2024
Closed
Merged
Merged
Merged
@mergify mergify bot merged commit 75d9079 into sigp:unstable Dec 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jxs jxs jxs approved these changes

@dapplion dapplion dapplion approved these changes

Assignees

No one assigned

Labels

das Data Availability Sampling ready-for-merge This PR is ready to merge.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ackintosh @jimmygchen @jxs @dapplion